From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B480235B634; Thu, 2 Apr 2026 20:04:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775160260; cv=none; b=Ax2KisvsZi5WGzg4I1cWkOe3O/fugcdXmU9BcJ1GqU+PmKvGBW2x5QU8Ppt2h6jo1VE1hG5Kbo8+LffDSLgveNrBpjJIQNvenTEopt2uDwO7w8D80MJ5leIhhOXaOF6/AI6Q0fZEKVX028xzdBrJGE8hC884ZWEqq/jSG4Nx+yE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775160260; c=relaxed/simple; bh=59lpSwsoPpnlu+KIsVuLkTwpGQQdzM03XV15lTdhlKo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=Pk3/bNYhy6FwgHGVBHBOoIhImnYEwOkt58ZFXVIu3rKmI/mzW6zntvon3iHFwnyUulJ+HvPzsrwbABLH6pARLLuemRMDfJrD0fWcrjE5p7FTRZacCk1JDK3BmM3JmTueFDdUlLLSFR1ZrI6OA0zSAzOkUxWd8gmlXuTXKBdDYsw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=Bilblz1n; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="Bilblz1n" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=rVNvoOyuAC1qL9Vomz/I3YhnB7WdDWRcRsIwqGMBANc=; b=Bilblz1nKLOlJmJvg/1eS2xGgM +fs8I4ECzCdcl1J6q9bog3G7S7rYGCUacEkmpUpe7KvdhfsMyhSvH+7ytcOq1OH67ynT43MS2S5UW 9Nrv32IP6vifAzdJSDkonLl2VfByLS6B+RbrXj22suhe4l+Wk4rN9sxkCyzmMEMTCjlY=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1w8OGx-00EZ93-FQ; Thu, 02 Apr 2026 22:04:11 +0200 Date: Thu, 2 Apr 2026 22:04:11 +0200 From: Andrew Lunn To: Joel Cc: andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, pabeni@redhat.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] sungem: fix PHY initialization hardware failure check and pointe style Message-ID: <4c17e602-e9ba-4ea5-993f-27a221a24ea0@lunn.ch> References: <20260402194235.11986-1-joelcrouch@gmail.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260402194235.11986-1-joelcrouch@gmail.com> On Thu, Apr 02, 2026 at 07:42:35PM +0000, Joel wrote: > Currently, bcm5411_init does not validate the result of the PHY register > reads. This can lead to silent failures if the hardware is unresponsive > or the MDIO bus times out, as 0xffff would be treated as valid data. > > This patch: > 1: Adds a check for -EIO and 0xffff during BCM5411 initialization. > 2: Updates gem_init_phy to log an error message fi the PHY- > specific init fails. > 3: Cleans up pointer formatting(eg,. foo* bar to foo *bar) to > align with Linux Kernel Coding Style in the modified files. A patch which does three things should probably be three patches. We want lots of small patches, with good commit messages, which are obviously correct. Code style changes should definitely be in a different patch to real changes. https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html Andrew --- pw-bot: cr