Re: [PATCH net-next 1/3] net: phy: phy-c45: add OATC10 Sleep/Wakeup support in 10BASE-T1S PHYs

[<Parthiban.Veerasooran@microchip.com>]

Hi Andrew,

On 30/03/26 8:16 pm, Andrew Lunn wrote:
> EXTERNAL EMAIL: Do not click links or open attachments unless you know the content is safe
> 
>> +     /* Cache PLCA settings for later use. These values must be restored when
>> +      * the PHY wakes up from the low-power sleep state, as all configured
>> +      * settings are lost.
>> +      */
> 
> Does the standard define that this configuration is lost in low power
> mode? If the standard says this, then fine. But if not, it should be
> the PHY driver which saves its state during suspend, and restores it
> during resume.

Thank you for the review and pointing this out.

You are correct that the Open Alliance TC10 specification does not 
explicitly state that PHY configuration is lost when entering the 
low‑power state. My earlier assumption was based on the LAN8670/1/2 PHY 
implementation, where the 'monitor and react to wake event' block 
remains active while other power supplies are switched off, resulting in 
configuration loss.

However, since this behavior is not mandated by the specification and 
may vary across PHY implementations, it should not be handled within the 
generic PHY framework.

Given this, I agree that state save and restore is PHY‑specific 
behavior. I will move this logic into the lan867x PHY driver in the next 
revision.

Moreover I will revisit the implementation with internal review and then 
post the next version. Thank you for your support.

Best regards,
Parthiban V
> 
>      Andrew