From: Vadim Fedorenko <vadim.fedorenko@linux.dev>
To: Max Georgiev <glipus@gmail.com>
Cc: kuba@kernel.org, netdev@vger.kernel.org,
maxime.chevallier@bootlin.com, vladimir.oltean@nxp.com,
richardcochran@gmail.com, gerhard@engleder-embedded.com,
thomas.petazzoni@bootlin.com,
"Köry Maincent" <kory.maincent@bootlin.com>
Subject: Re: [RFC PATCH v4 0/5] New NDO methods ndo_hwtstamp_get/set
Date: Sat, 29 Apr 2023 20:44:57 +0100 [thread overview]
Message-ID: <4c27d467-95a3-fb9a-52be-bcb54f7d1aaf@linux.dev> (raw)
In-Reply-To: <CAP5jrPH1=fw7ayEFuzQZKXSkcXeGfUy134yEANzDcSyvwOB-2g@mail.gmail.com>
On 28.04.2023 15:14, Max Georgiev wrote:
> On Fri, Apr 28, 2023 at 2:11 AM Köry Maincent <kory.maincent@bootlin.com> wrote:
>>
>> On Thu, 27 Apr 2023 22:57:27 -0600
>> Max Georgiev <glipus@gmail.com> wrote:
>>
>>> Sorry, I'm still learning the kernel patch communication rules.
>>> Thank you for guiding me here.
>>
>> Also, each Linux merging subtree can have its own rules.
>> I also, was not aware of net special merging rules:
>> https://www.kernel.org/doc/html/latest/process/maintainer-netdev.html
>>
>>
>>> On Thu, Apr 27, 2023 at 2:43 AM Köry Maincent <kory.maincent@bootlin.com>
>>> wrote:
>>>>
>>>> On Wed, 26 Apr 2023 22:00:43 -0600
>>>> Max Georgiev <glipus@gmail.com> wrote:
>>>>
>>>>>
>>>>> Thank you for giving it a try!
>>>>> I'll drop the RFC tag starting from the next iteration.
>>>>
>>>> Sorry I didn't know the net-next submission rules. In fact keep the RFC tag
>>>> until net-next open again.
>>>> http://vger.kernel.org/~davem/net-next.html
>>>>
>>>> Your patch series don't appear in the cover letter thread:
>>>> https://lore.kernel.org/all/20230423032437.285014-1-glipus@gmail.com/
>>>> I don't know if it comes from your e-mail or just some issue from lore but
>>>> could you check it?
>>>
>>> Could you please elaborate what's missing in the cover letter?
>>> Should the cover letter contain the latest version of the patch
>>> stack (v4, then v5, etc.) and some description of the differences
>>> between the patch versions?
>>> Let me look up some written guidance on this.
>>
>> I don't know how you send your patch series but when you look on your e-mail
>> thread the patches are not present:
>> https://lore.kernel.org/all/20230423032437.285014-1-glipus@gmail.com/
>>
>> It is way easier to find your patches when you have all the patches of the
>> series in the e-mail thread.
>>
>
> Aha, I see the problem now. I guess it has something to do with "--in-reply-to"
> git send-email optio or similar options.
>
>> Here for example they are in the thread:
>> https://lore.kernel.org/all/20230406173308.401924-1-kory.maincent@bootlin.com/
>>
>> Do you use git send-email?
>
> Yes, I use "git format-patch" to generate individual patch files for
> every patch in the
> stack, and then I use "git send-email" to send out these patches on-by-one.
>
The problem is, as Köry has mentioned already, in sending patches one-by-one.
You can provide a directory with patches to git send-email and it will take all
of them at once. You can try it with --dry-run and check that all pacthes have
the same In-Reply-To and References headers.
> Is there a recommended way to send out stacks of patches?
next prev parent reply other threads:[~2023-04-29 19:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-23 3:24 [RFC PATCH v4 0/5] New NDO methods ndo_hwtstamp_get/set Maxim Georgiev
2023-04-26 16:58 ` Köry Maincent
2023-04-27 4:00 ` Max Georgiev
2023-04-27 8:43 ` Köry Maincent
2023-04-28 4:57 ` Max Georgiev
2023-04-28 8:11 ` Köry Maincent
2023-04-28 14:14 ` Max Georgiev
2023-04-28 14:34 ` Köry Maincent
2023-04-29 19:44 ` Vadim Fedorenko [this message]
2023-05-02 4:35 ` Max Georgiev
2023-05-02 4:44 ` Max Georgiev
2023-05-02 9:13 ` Köry Maincent
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c27d467-95a3-fb9a-52be-bcb54f7d1aaf@linux.dev \
--to=vadim.fedorenko@linux.dev \
--cc=gerhard@engleder-embedded.com \
--cc=glipus@gmail.com \
--cc=kory.maincent@bootlin.com \
--cc=kuba@kernel.org \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=thomas.petazzoni@bootlin.com \
--cc=vladimir.oltean@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).