From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ED88BC43387 for ; Fri, 18 Jan 2019 01:02:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B3BFF2087E for ; Fri, 18 Jan 2019 01:02:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="qmu+zf6C" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726147AbfARBCi (ORCPT ); Thu, 17 Jan 2019 20:02:38 -0500 Received: from mail-pl1-f195.google.com ([209.85.214.195]:36584 "EHLO mail-pl1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725992AbfARBCi (ORCPT ); Thu, 17 Jan 2019 20:02:38 -0500 Received: by mail-pl1-f195.google.com with SMTP id g9so5550604plo.3 for ; Thu, 17 Jan 2019 17:02:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=lpy9sMREcjZnhvAMAgYlM6EfFJK32DoMxskrA728Gm8=; b=qmu+zf6CKQMEAC1jM0lab9EN06cAdZ5gy2vnDtK4O8zJLeSQ4+R+izRJqxgJxHOaEW uR2CAMwPS1HhUcAMZjNmuIKZ94QHc7Olf+Hpnv/iDyfL+Yx99ED5BAJeIQGgA1cS885u CL0eRxX9hoiRxTRFLHDz68Kd5KZZ6uGQYqo5h9bhrSV0zbB2eB2Jxj1wcNDziA/Qgww8 me+TP1BZZo8qVrqCuPAPWm2RAzGiX4qp3Ug4xxMJlqWGb6bo0iN+epv39O5lVy0mC0Tr 9985D8kMX1ENrPVCrf/st8j93lsbVTbLR9N7bbLQkXgEIyRcnuolPyP582JYwog2lnVh lqCA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=lpy9sMREcjZnhvAMAgYlM6EfFJK32DoMxskrA728Gm8=; b=qQESqK3h2QJkHjDSOJnDfUAwb+YyXNU4EZsga65lX+4p9XadJvnljPDN31dtrBbvEe ppD7uC/5kmknon4CjQvm9R7wCiaZMfZlodw1eDCG3uGO+ogdUcxBor093s+CkYkMiA3F WTRPuVhh2rUR54X3AtQhD9Dhu0S7UviQyJbPlsZOrXe8pDYHYj545gHLh8/nM/zvsQaK NvaOyrKz0QTOjClcA5b4hgJO/eMGNp4pgipb6KYYfzIZdAnYXVgmFknKkCgk+Qx0Whp5 BdLhC697pL7r/I7JM++HMHyzMTvOFutemmN5JtdaFhyE2IOXVkF5+SMEiF5CIW4eMXeC zgmg== X-Gm-Message-State: AJcUukcWx+lVwjNBMSR98ik3BP6XOQasqST0sSOMaJ6CspaDpKRDZo0m U0vmRFu9igtY+KrOlhX76x3UC6fF X-Google-Smtp-Source: ALg8bN4SnhIYdqp7WxLERpNlkDiZUECyGkV/hcsoWbU9In3lVDQNCkAQsy2VC7vYkfjMkZXP1Q0t3Q== X-Received: by 2002:a17:902:b112:: with SMTP id q18mr17161544plr.255.1547773357567; Thu, 17 Jan 2019 17:02:37 -0800 (PST) Received: from ?IPv6:2620:15c:2c1:200:55c7:81e6:c7d8:94b? ([2620:15c:2c1:200:55c7:81e6:c7d8:94b]) by smtp.gmail.com with ESMTPSA id i1sm3596440pgb.46.2019.01.17.17.02.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 17:02:35 -0800 (PST) Subject: Re: [PATCH bpf-next 0/5] add bpf cgroup hooks that trigger on socket close To: Stanislav Fomichev , netdev@vger.kernel.org Cc: davem@davemloft.net, ast@kernel.org, daniel@iogearbox.net References: <20190118004106.163825-1-sdf@google.com> From: Eric Dumazet Message-ID: <4c553acb-027c-01ba-2593-b8edd75e4fbd@gmail.com> Date: Thu, 17 Jan 2019 17:02:34 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190118004106.163825-1-sdf@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 01/17/2019 04:41 PM, Stanislav Fomichev wrote: > Currently, we have BPF_CGROUP_INET_SOCK_CREATE hook that triggers on > socket creation and there is no way to know when the socket is being > closed. Add new set of hooks BPF_CGROUP_INET{4,6}_SOCK_RELEASE > that trigger when the socket is closed. > Are these hooks enough to capture a disconnect() operation ? A socket can be reused (different flows) without inet_release() being ever called. > Initial intended usecase is to cleanup statistics after POST{4,6}_BIND. > Hooks have read-only access to all fields of struct bpf_sock. > > First patch adds hooks, the rest of the patches add uapi and tests to make > sure these hooks work. >