From: Paolo Abeni <pabeni@redhat.com>
To: Jan Hoffmann <jan@3e8.eu>, Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>,
Daniel Golle <daniel@makrotopia.org>,
Markus Stockhausen <markus.stockhausen@gmx.de>,
Damien Dejean <dam.dejean@gmail.com>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2] net: phy: realtek: support MDI swapping for RTL8226-CG
Date: Tue, 31 Mar 2026 15:24:33 +0200 [thread overview]
Message-ID: <4c7118f6-425b-4584-86fb-97f2a68c4474@redhat.com> (raw)
In-Reply-To: <20260327202001.413280-1-jan@3e8.eu>
On 3/27/26 8:32 PM, Jan Hoffmann wrote:
> +static int rtl8226_config_mdi_order(struct phy_device *phydev)
> +{
> + u32 order;
> + int ret;
> +
> + ret = of_property_read_u32(phydev->mdio.dev.of_node, "enet-phy-pair-order", &order);
> +
> + /* Property not present, nothing to do */
> + if (ret == -EINVAL || ret == -ENOSYS)
> + return 0;
> +
> + if (ret)
> + return ret;
> +
> + /* Only enabling MDI swapping is supported */
> + if (order != 1)
> + return -EINVAL;
I guess some existing setup may have "enet-phy-pair-order" == 0, and the
above will make them fail. I think you should just pass with no action
in such a case.
/P
next prev parent reply other threads:[~2026-03-31 13:24 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-27 19:32 [PATCH net-next v2] net: phy: realtek: support MDI swapping for RTL8226-CG Jan Hoffmann
2026-03-31 13:24 ` Paolo Abeni [this message]
2026-03-31 13:38 ` Russell King (Oracle)
2026-04-03 18:49 ` Jan Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c7118f6-425b-4584-86fb-97f2a68c4474@redhat.com \
--to=pabeni@redhat.com \
--cc=andrew@lunn.ch \
--cc=dam.dejean@gmail.com \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=jan@3e8.eu \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=markus.stockhausen@gmx.de \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox