From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7266CC00A89 for ; Mon, 2 Nov 2020 22:36:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8A3820870 for ; Mon, 2 Nov 2020 22:36:46 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604356607; bh=M77JQwpHVytx1fH56+uLb62c1dilDbZryCn3QRwJzmk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:List-ID:From; b=q9IK+tJQaw1qC+kYKJXY9R+NmGP5dlqdTuwWe/UGMSZelOM+OALegGvu5b1oPM9dj LqCysv4yihbtqDlTZjdxV+RGEthGd9sbwS/U3Vbcoj2NWj/FgZG/qxFmX0jJLzhwew WuSAkZFjkB6hld9VUNkN5F/wuIrAX8LaPK/xyaFc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726561AbgKBWgp (ORCPT ); Mon, 2 Nov 2020 17:36:45 -0500 Received: from mail.kernel.org ([198.145.29.99]:54956 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725807AbgKBWgp (ORCPT ); Mon, 2 Nov 2020 17:36:45 -0500 Received: from lt-jalone-7480.mtl.com (c-24-6-56-119.hsd1.ca.comcast.net [24.6.56.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6795B20786; Mon, 2 Nov 2020 22:36:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1604356605; bh=M77JQwpHVytx1fH56+uLb62c1dilDbZryCn3QRwJzmk=; h=Subject:From:To:Cc:Date:In-Reply-To:References:From; b=mtEFA7EL69HW3/33YCjCSwvlSwXqVsri+z36u12G6vwVtzIl3Qoptf2JQCQsRY9+Q cprNPSh5aWiDaQ7SyQ7/C/sHTMMAwkalPWM1PMepiPzqMV1aq6OFV2b+cT0qD1bKvt VFES6bdwz4LcQvfkpJIXMqNfWMXc4c01QTKaIKCg= Message-ID: <4ca1f21d5f8a119fe6483df370b64af6a33e565e.camel@kernel.org> Subject: Re: [PATCH net-next 0/5] net: add and use dev_get_tstats64 From: Saeed Mahameed To: Heiner Kallweit , Jakub Kicinski , David Miller , Alexey Kuznetsov , Hideaki YOSHIFUJI , Andrew Lunn , Vivien Didelot , Florian Fainelli , Vladimir Oltean , Russell King Cc: "netdev@vger.kernel.org" Date: Mon, 02 Nov 2020 14:36:43 -0800 In-Reply-To: <25c7e008-c3fb-9fcd-f518-5d36e181c0cb@gmail.com> References: <25c7e008-c3fb-9fcd-f518-5d36e181c0cb@gmail.com> Content-Type: text/plain; charset="UTF-8" User-Agent: Evolution 3.36.5 (3.36.5-1.fc32) MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Sun, 2020-11-01 at 13:33 +0100, Heiner Kallweit wrote: > It's a frequent pattern to use netdev->stats for the less frequently > accessed counters and per-cpu counters for the frequently accessed > counters (rx/tx bytes/packets). Add a default ndo_get_stats64() > implementation for this use case. Subsequently switch more drivers > to use this pattern. > > Heiner Kallweit (5): > net: core: add dev_get_tstats64 as a ndo_get_stats64 implementation > net: make ip_tunnel_get_stats64 an alias for dev_get_tstats64 > ip6_tunnel: use ip_tunnel_get_stats64 as ndo_get_stats64 callback > net: dsa: use net core stats64 handling > tun: switch to net core provided statistics counters > not many left, $ git grep dev_fetch_sw_netstats drivers/ drivers/infiniband/hw/hfi1/ipoib_main.c: dev_fetch_sw_netstats(s torage, priv->netstats); drivers/net/macsec.c: dev_fetch_sw_netstats(s, dev->tstats); drivers/net/usb/qmi_wwan.c: dev_fetch_sw_netstats(stats, priv- >stats64); drivers/net/usb/usbnet.c: dev_fetch_sw_netstats(stats, dev- >stats64); drivers/net/wireless/quantenna/qtnfmac/core.c: dev_fetch_sw_netstats(s tats, vif->stats64); Why not convert them as well ? macsec has a different implementation, but all others can be converted.