From: Marc Kleine-Budde <mkl@pengutronix.de>
To: Yegor Yefremov <yegorslists@googlemail.com>,
linux-can@vger.kernel.org, netdev <netdev@vger.kernel.org>
Subject: Re: [PATCH] can: j1939: convert PGN structure to a table
Date: Tue, 27 Oct 2020 13:15:45 +0100 [thread overview]
Message-ID: <4ca7cb3c-554c-7fcd-8d8f-369fce222c5a@pengutronix.de> (raw)
In-Reply-To: <CAGm1_kuZkrbaLwATrbPkmDmQW7SAwDapy5jbT8EwOSmccGqV0A@mail.gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1213 bytes --]
On 10/27/20 12:27 PM, Yegor Yefremov wrote:
>>> Can you add a row description that indicated that these numbers are. They are
>>> probably bit positions within the CAN-ID?
>>
>> This is true for up to 99.9%, depending on who you ask.
>> this maps indeed to the bit positions in the CAN-ID, as in J1939-21.
>> The trouble is that PGN's are also communicated as such in the payload,
>> e.g. in the TP and ETP (see J1939-81 if i remember correctly).
>> Since only PGN is written there, without SA, the bit position relative
>> to the CAN-ID are ... making things look fuzzy.
>>
>> So I the best I can propose is to add a 2nd row :-)
Sounds reasonable.
> I have sent v2. Should I also include the tables for PDU1 and PDU2
> formats as well as the general table with ID and Data? See Wiki [1]
Make it so.
> [1] https://de.wikipedia.org/wiki/SAE_J1939#/media/Datei:J1939_Aufsplittung_CAN-Identifier.png
regards,
Marc
--
Pengutronix e.K. | Marc Kleine-Budde |
Embedded Linux | https://www.pengutronix.de |
Vertretung West/Dortmund | Phone: +49-231-2826-924 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
prev parent reply other threads:[~2020-10-27 12:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-22 10:29 [PATCH] can: j1939: convert PGN structure to a table yegorslists
2020-10-22 10:33 ` Marc Kleine-Budde
2020-10-22 12:24 ` Kurt Van Dijck
2020-10-27 11:27 ` Yegor Yefremov
2020-10-27 12:15 ` Marc Kleine-Budde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ca7cb3c-554c-7fcd-8d8f-369fce222c5a@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=linux-can@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=yegorslists@googlemail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox