From: Eric Dumazet <eric.dumazet@gmail.com>
To: Saeed Mahameed <saeedm@mellanox.com>,
"eric.dumazet@gmail.com" <eric.dumazet@gmail.com>,
"davem@davemloft.net" <davem@davemloft.net>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section
Date: Mon, 16 Apr 2018 14:07:07 -0700 [thread overview]
Message-ID: <4cc44e85-cb5e-502c-30f3-c6ea564fe9ac@gmail.com> (raw)
In-Reply-To: <1523911853.4579.19.camel@mellanox.com>
On 04/16/2018 01:50 PM, Saeed Mahameed wrote:
>
> Dave, Eric, I would like to know whether it is ok to have this change
> in the kernel (make get_stats ndo "might sleep")? I really didn't get
> any convincing feedback to not do this change.
Fact that you were not convinced does not mean you were right.
I would rather not change the current behavior and risk nasty bugs.
Having SNMP daemons blocked while some device is sleeping in its ndo_get_stats()
is concerning, since it is currently an immediate operation.
ethtool -S can definitely sleep if you need fancy stats.
prev parent reply other threads:[~2018-04-16 21:07 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-10 17:08 [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock critical section Saeed Mahameed
2018-04-10 17:08 ` [RFC net-next 2/2] net: net-sysfs: Reduce netstat_show read_lock " Saeed Mahameed
2018-04-10 17:17 ` David Miller
2018-04-10 17:16 ` [RFC net-next 1/2] net: net-porcfs: Reduce rcu lock " David Miller
2018-04-10 20:35 ` Eric Dumazet
2018-04-11 18:59 ` Saeed Mahameed
2018-04-11 22:30 ` Eric Dumazet
2018-04-11 23:47 ` Saeed Mahameed
2018-04-12 2:59 ` Eric Dumazet
2018-04-12 19:12 ` Saeed Mahameed
2018-04-16 20:50 ` Saeed Mahameed
2018-04-16 21:07 ` Eric Dumazet [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cc44e85-cb5e-502c-30f3-c6ea564fe9ac@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=netdev@vger.kernel.org \
--cc=saeedm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).