From: Paolo Abeni <pabeni@redhat.com>
To: Ido Schimmel <idosch@nvidia.com>,
netdev@vger.kernel.org, linux-kselftest@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
shuah@kernel.org, razor@blackwall.org
Subject: Re: [PATCH net-next] selftests: net: Fix bridge backup port test flakiness
Date: Thu, 01 Feb 2024 10:34:52 +0100 [thread overview]
Message-ID: <4cca1f0d3c015a6ab9e371b1639f6c3c29b33024.camel@redhat.com> (raw)
In-Reply-To: <20240201080516.3585867-1-idosch@nvidia.com>
On Thu, 2024-02-01 at 10:05 +0200, Ido Schimmel wrote:
> The test toggles the carrier of a bridge port in order to test the
> bridge backup port feature.
>
> Due to the linkwatch delayed work the carrier change is not always
> reflected fast enough to the bridge driver and packets are not forwarded
> as the test expects, resulting in failures [1].
>
> Fix by adding a one second delay after a carrier change in places where
> a packet is sent immediately after the carrier change.
What about adding an helper alike wait_local_port_listen(), checking
for bridge link status in short intervals, to likely reduce the overall
wait time?
Thanks,
Paolo
next prev parent reply other threads:[~2024-02-01 9:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-01 8:05 [PATCH net-next] selftests: net: Fix bridge backup port test flakiness Ido Schimmel
2024-02-01 9:34 ` Paolo Abeni [this message]
2024-02-01 11:16 ` Ido Schimmel
2024-02-01 12:31 ` Paolo Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4cca1f0d3c015a6ab9e371b1639f6c3c29b33024.camel@redhat.com \
--to=pabeni@redhat.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=idosch@nvidia.com \
--cc=kuba@kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=razor@blackwall.org \
--cc=shuah@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox