public inbox for netdev@vger.kernel.org
 help / color / mirror / Atom feed
From: Gerd Rausch <gerd.rausch@oracle.com>
To: Fernando Fernandez Mancera <fmancera@suse.de>,
	Eric Dumazet <edumazet@google.com>,
	syzbot <syzbot+5efae91f60932839f0a5@syzkaller.appspotmail.com>
Cc: davem@davemloft.net, dsahern@kernel.org, horms@kernel.org,
	kuba@kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, pabeni@redhat.com,
	syzkaller-bugs@googlegroups.com
Subject: Re: [syzbot] [net?] possible deadlock in inet6_getname
Date: Tue, 17 Feb 2026 09:13:31 -0800	[thread overview]
Message-ID: <4cd4099b-328d-45eb-990d-793df79cd639@oracle.com> (raw)
In-Reply-To: <1c5ce96c-3b01-44e0-8dc9-5c54e504cb95@suse.de>

Hi,

On 2026-02-17 09:03, Fernando Fernandez Mancera wrote:
>> rds_tcp_conn_slots_available() can also be called from rds_conn_shutdown(),
>> where no "rds_tcp.ko" backend specific lock is held.
>>
> 
> 
> AFAICS, from rds_conn_shutdown() path rds_tcp_conn_slots_available() is called with fan-out argument as false. Therefore, no need to get the peer source port.
> 
> I think that should be fine.
> 

True, but IMHO subtle and error-prone.

If someone were to change the code to pass in "fan_out == true"
from a context not already holding a socket lock,
would they remember to change rds_tcp_conn_slots_available()
to acquire that lock?

Thanks,

   Gerd


  reply	other threads:[~2026-02-17 17:13 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-13 12:15 [syzbot] [net?] possible deadlock in inet6_getname syzbot
2026-02-13 17:26 ` Eric Dumazet
2026-02-13 18:51   ` Gerd Rausch
2026-02-14 18:25     ` Fernando Fernandez Mancera
2026-02-17 16:59       ` Gerd Rausch
2026-02-17 17:03         ` Fernando Fernandez Mancera
2026-02-17 17:13           ` Gerd Rausch [this message]
2026-02-17 17:19             ` Fernando Fernandez Mancera
2026-02-17 17:28               ` Gerd Rausch
2026-02-17 18:58                 ` Gerd Rausch
2026-02-17 20:26                   ` Fernando Fernandez Mancera
2026-02-17 21:57                     ` Allison Henderson
2026-02-16 11:32 ` Fernando Fernandez Mancera
2026-02-16 11:45   ` syzbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4cd4099b-328d-45eb-990d-793df79cd639@oracle.com \
    --to=gerd.rausch@oracle.com \
    --cc=davem@davemloft.net \
    --cc=dsahern@kernel.org \
    --cc=edumazet@google.com \
    --cc=fmancera@suse.de \
    --cc=horms@kernel.org \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=syzbot+5efae91f60932839f0a5@syzkaller.appspotmail.com \
    --cc=syzkaller-bugs@googlegroups.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox