From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from vps0.lunn.ch (vps0.lunn.ch [156.67.10.101]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7C4A1E8329 for ; Fri, 7 Nov 2025 13:30:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=156.67.10.101 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762522242; cv=none; b=q6o+/Romxlv8Bd97dIh2nnqe60UvKNetjhxTCzrlxbsrv9eSGqe+oTmEidvKmmoVKe3L9YqTBYVFfm00snksuHXiYO7D8zLrcQfP4GvqHwqwRy1tWL2KeVr7fujzADO5PkxLmY4N2S57fESGJU8/ELbJUMAsyea1lbTMRBwcGeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762522242; c=relaxed/simple; bh=CB8LxivVfoJzTOIyp28RJYHNs0uHzInSlkVyRrsqnU4=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=P5eEP8MtRt9c7/wuCU77/JVN1pUwA4XQVOHQqANeHK1MzYPb6QMi+Nj0xX2Sk0KjjAJGYUEH7eDP246bczjLkz6AAEUZNoPfrvk/w3ZLVndS0QciKx+bRT6960OYwI6cL6EtNe081gbTWA/lpxU8qYT7BX9V0f0ecOoItdSrlKY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch; spf=pass smtp.mailfrom=lunn.ch; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b=EXytYuNb; arc=none smtp.client-ip=156.67.10.101 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lunn.ch Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lunn.ch Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=lunn.ch header.i=@lunn.ch header.b="EXytYuNb" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=wCtHp+RTMDsXZkrypzcXqyWr80jozipO654ec5rQnQc=; b=EXytYuNb9nGQfuqYqwHInjD5lI Qc9/85uKbg2wJ+mv/UHeCH3i0ywv7kMZNFlY+oCOmxxw2rzmrnbr4YGTXO/psB91iLCEPgWad/l8N yYQnahrGBK+BpsaYN9rkwgOzyzK3ZbxtqTiO8rzEF8E5sTj1g43ky/GEJSbjNCph3NMs=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1vHMY2-00DEKT-OF; Fri, 07 Nov 2025 14:30:38 +0100 Date: Fri, 7 Nov 2025 14:30:38 +0100 From: Andrew Lunn To: Vladimir Oltean Cc: netdev@vger.kernel.org, Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Marek Vasut , Wei Fang , Clark Wang Subject: Re: [PATCH v2 net-next 5/6] net: phy: realtek: eliminate priv->phycr1 variable Message-ID: <4ce87e6e-ee6e-4d3c-a5f0-73081999f5ea@lunn.ch> References: <20251107110817.324389-1-vladimir.oltean@nxp.com> <20251107110817.324389-6-vladimir.oltean@nxp.com> Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20251107110817.324389-6-vladimir.oltean@nxp.com> On Fri, Nov 07, 2025 at 01:08:16PM +0200, Vladimir Oltean wrote: > Previous changes have replaced the machine-level priv->phycr2 with a > high-level priv->disable_clk_out. This created a discrepancy with > priv->phycr1 which is resolved here, for uniformity. > > One advantage of this new implementation is that we don't read > priv->phycr1 in rtl821x_probe() if we're never going to modify it. > > We never test the positive return code from phy_modify_mmd_changed(), so > we could just as well use phy_modify_mmd(). > > I took the ALDPS feature description from commit d90db36a9e74 ("net: > phy: realtek: add dt property to enable ALDPS mode") and transformed it > into a function comment - the feature is sufficiently non-obvious to > deserve that. > > Signed-off-by: Vladimir Oltean Reviewed-by: Andrew Lunn Andrew