From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BBE463ED10E for ; Tue, 31 Mar 2026 09:28:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774949318; cv=none; b=SszNyotgGMphEQP23RNQksDjIyVbpk1tRztt+Qu576BUuabCeCwuO8XxijGOr/PNP3+DN9sq6V0dQLOYOE5eL/fIKAdkoOHBJXDFBpjIXfGmGfos8xKr0dkrv/+oNBAY8T9PotkLtLwZS1N3oMsFhFJhBBEJi9SmC997Uc02BaI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1774949318; c=relaxed/simple; bh=NBrawPDPzTZMShXyjuHEmK45v2SuMkUgHKMBfO43mGw=; h=Message-ID:Date:MIME-Version:Subject:To:References:From: In-Reply-To:Content-Type; b=cIOI8xte5oYGvgB0VbKSchHwpZbCMe4QXBoWRetXAx/VKwRF+L1CSEJ/KAbfFntbvGciDLZwY+2WOICd50BhIzB1aU3lLeBIjO0xUEVcrJEGJ5JpBRW7A8IpQbMJR7DffmqGk5a94hagyI0YGas1quOX7rIHudY07DGXaXQEYng= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=B6UEHan3; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=N5eC38D3; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="B6UEHan3"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="N5eC38D3" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1774949315; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hE/wELyunyzB08vE4KhsobAhK0D+1FSIRk8/BrdctfY=; b=B6UEHan3/bdx9LBLpOIsUjPJdE85SDAJpxJlLwySJE0n7+j7d0CFtd+n3gzOab1SpbmEf2 tXfzWpuo74rAcArbx4aczQmrgR5s/xGcQjVdKGaqHJGk8FENWzfjyzpfH36YDNnvlaflU9 ZjzYXfH2V23g9Xsj0o7ct/58EZnzoN0= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-456-6NIsDxZjPuyTWh6PBnyxRQ-1; Tue, 31 Mar 2026 05:28:34 -0400 X-MC-Unique: 6NIsDxZjPuyTWh6PBnyxRQ-1 X-Mimecast-MFC-AGG-ID: 6NIsDxZjPuyTWh6PBnyxRQ_1774949313 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4887e4b338bso3383215e9.1 for ; Tue, 31 Mar 2026 02:28:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1774949313; x=1775554113; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id:from :to:cc:subject:date:message-id:reply-to; bh=hE/wELyunyzB08vE4KhsobAhK0D+1FSIRk8/BrdctfY=; b=N5eC38D3VSqiSaDDKcypzkI+9lJii27dNI57bI5KAGArrw8CfL+atLf7RYe1BG5KWm 5q6s3/F3uyHG02aTHrUefzk7aIFub07IJjTZFoR+TgxWrFynfkWGRsS0X5W2lkeqWjFE Gx31ycNIZ+N+BCLCvJK/7IzsjuUqjeB6mqAgKleYVViGdyEVpsKrsPrdI2vgNZjyRCMW xry8664sQwvFTy/q66ZIRYfhxmgv6Vv9aPIy7O52+2bNso80UoU6VUub3c+KOontEXik kp0yV0z4St18a18S/JRFK8ZW9qdtx3LtLQl1FBXbbYeuDkDQt9RgxewqV9RThNZb0Tjw 9Bjg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1774949313; x=1775554113; h=content-transfer-encoding:in-reply-to:from:content-language :references:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=hE/wELyunyzB08vE4KhsobAhK0D+1FSIRk8/BrdctfY=; b=OzFst+L+oKZU0ok3ulg7yMHehZOdnoFp4aaisBDmBy4tDwtE9JAVjC7WBR2Rh4pZLD GUbGW+NlMcwKbNdTehl6byfKlVEVojDJc9bs5tD7OJT85Foh5WdGBPpOaHoIjxVgLNSo t0Do8LpyYXiT++ct8sVU3sXTO45lgm9QWtbcE8X8c8k23dvJyi/8yA7A0awuqJEAJ+m6 U94TNtutchV6ij5xqhV8fLoSMiaV1wJD0Nmapea6R8FaoYt7Hj//sPjqrT/Sv8czlORn ygHNTFdrmakU1Kfy9wKLFF5oAwmPplxREo2u+VikxZP27PBfjkknsTUvEFTjJBvbXI63 eGeA== X-Forwarded-Encrypted: i=1; AJvYcCXJkqh3GHSA+An68AuZ2q0MZSPG61TOiSfxSsbUqNHh2SNOS4XE2RlUQojsb6CRKymPEZVLEzI=@vger.kernel.org X-Gm-Message-State: AOJu0YwpFd0nLCQUFKhka5BKX82JWvObWSVw1zOna3IS5AzfzW3a0AUc smgJCwkXj7M87cpKxBf+N6ftxjCOsiVQkWev642vhMzO0xWkzBf7Gzzi/qe+0+cXyur4qpulRSW Y1JI14wiFYXVcYVOGNUd572Kq9S7onTq9zM3TaozhOVLOkgaOujLzgWMG0w== X-Gm-Gg: ATEYQzzahFJlqFuX+SVI1hDLBCtUE/Ir8mWI3mDWIj5lkxUe+LH8RqA9Pj0VhkU/fDs bQLuCdZmJC2uMwYyE/jmJ3hpPwUoHpOfJTMYx/ovPrhOuquVOdA1oi8/WPytKADzKE0SyTB65cQ XF+XnRDZe+3aKYcCJyjmnZ8mJLMoPHo4j3MbIcCdkFqQYhC9IZ/0V7bV87okuSoqoFNEQl15no1 YOFlTBnQqu0jLD0PwwYF2Fa5XAnVltSxp3cZjRTLQ9IfzaAPeh4R89uZ985ldm0Nunq2UmH9zaD Nt/FQXS0t1f3IFG4D7e7sloQCi75A9/5HPtwNM3RLOfqmJBRP8qcDi03R2ytOt2GgPg9O4U8FRp 7+S2GekOdTWMTBmcnavebu2tpW0zxFpGboNCEflT3dgUqVCGQcKccRN1f X-Received: by 2002:a05:600c:1986:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488783a6913mr42729875e9.12.1774949313121; Tue, 31 Mar 2026 02:28:33 -0700 (PDT) X-Received: by 2002:a05:600c:1986:b0:486:faa8:9e4 with SMTP id 5b1f17b1804b1-488783a6913mr42729325e9.12.1774949312589; Tue, 31 Mar 2026 02:28:32 -0700 (PDT) Received: from [192.168.88.32] ([212.105.155.58]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4887c77df84sm17291665e9.4.2026.03.31.02.28.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 31 Mar 2026 02:28:32 -0700 (PDT) Message-ID: <4ceecee2-ea5a-4026-ad38-66c0a7d263cd@redhat.com> Date: Tue, 31 Mar 2026 11:28:30 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH net-next] net: mana: hardening: Validate adapter_mtu from MANA_QUERY_DEV_CONFIG To: Erni Sri Satya Vennela , kys@microsoft.com, haiyangz@microsoft.com, wei.liu@kernel.org, decui@microsoft.com, longli@microsoft.com, andrew+netdev@lunn.ch, davem@davemloft.net, edumazet@google.com, kuba@kernel.org, ssengar@linux.microsoft.com, dipayanroy@linux.microsoft.com, gargaditya@linux.microsoft.com, shirazsaleem@microsoft.com, kees@kernel.org, linux-hyperv@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org References: <20260326173101.2010514-1-ernis@linux.microsoft.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260326173101.2010514-1-ernis@linux.microsoft.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit On 3/26/26 6:30 PM, Erni Sri Satya Vennela wrote: > As a part of MANA hardening for CVM, validate the adapter_mtu value > returned from the MANA_QUERY_DEV_CONFIG HWC command. > > The adapter_mtu value is used to compute ndev->max_mtu via: > gc->adapter_mtu - ETH_HLEN. If hardware returns a bogus adapter_mtu > smaller than ETH_HLEN (e.g. 0), the unsigned subtraction wraps to a > huge value, silently allowing oversized MTU settings. > > Add a validation check to reject adapter_mtu values below > ETH_MIN_MTU + ETH_HLEN, returning -EPROTO to fail the device > configuration early with a clear error message. > > Signed-off-by: Erni Sri Satya Vennela > --- > drivers/net/ethernet/microsoft/mana/mana_en.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ethernet/microsoft/mana/mana_en.c b/drivers/net/ethernet/microsoft/mana/mana_en.c > index b39e8b920791..bd07d17a6017 100644 > --- a/drivers/net/ethernet/microsoft/mana/mana_en.c > +++ b/drivers/net/ethernet/microsoft/mana/mana_en.c > @@ -1207,10 +1207,16 @@ static int mana_query_device_cfg(struct mana_context *ac, u32 proto_major_ver, > > *max_num_vports = resp.max_num_vports; > > - if (resp.hdr.response.msg_version >= GDMA_MESSAGE_V2) > + if (resp.hdr.response.msg_version >= GDMA_MESSAGE_V2) { > + if (resp.adapter_mtu < ETH_MIN_MTU + ETH_HLEN) { > + dev_err(dev, "Adapter MTU too small: %u\n", > + resp.adapter_mtu); > + return -EPROTO; AI review says: If this returns -EPROTO, does the caller mana_probe() jump to an error label and call mana_remove()? If so, mana_remove() unconditionally calls disable_work_sync(&ac->link_change_work) and cancel_delayed_work_sync(&ac->gf_stats_work). Since mana_query_device_cfg() is called before INIT_WORK() and INIT_DELAYED_WORK() in the probe sequence, wouldn't this result in calling sync cancellation functions on uninitialized, zeroed work structures? This can lead to a WARN_ON(!work->func) in __flush_work(), or debug object warnings if CONFIG_DEBUG_OBJECTS_WORK is enabled. While this initialization issue appears to already exist for other early error paths, this new error path can also trigger it.