From mboxrd@z Thu Jan  1 00:00:00 1970
From: Eric Dumazet <eric.dumazet@gmail.com>
Subject: Re: [PATCH net-next] udp: Fix kernel panic in UDP GSO path
Date: Mon, 14 May 2018 16:10:45 -0700
Message-ID: <4cfbf250-84b3-363c-4c60-e62613f8aefb@gmail.com>
References: <1525999127-11585-1-git-send-email-stranche@codeaurora.org>
 <ffd8b916-a060-55b5-35c6-13cf81902301@gmail.com>
 <CAF=yD-JH8ahoLNKOVjBScRXKP4UQqQpfq89C6xq0=nwd3jQtzw@mail.gmail.com>
 <c86a2fbde50aea2b28e82c333f29d575@codeaurora.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Cc: Eric Dumazet <eric.dumazet@gmail.com>,
        Willem de Bruijn <willemb@google.com>,
        David Miller <davem@davemloft.net>,
        Network Development <netdev@vger.kernel.org>,
        Subash Abhinov Kasiviswanathan <subashab@codeaurora.org>
To: stranche@codeaurora.org,
        Willem de Bruijn <willemdebruijn.kernel@gmail.com>
Return-path: <netdev-owner@vger.kernel.org>
Received: from mail-pl0-f53.google.com ([209.85.160.53]:41977 "EHLO
        mail-pl0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752133AbeENXKr (ORCPT
        <rfc822;netdev@vger.kernel.org>); Mon, 14 May 2018 19:10:47 -0400
Received: by mail-pl0-f53.google.com with SMTP id az12-v6so8213743plb.8
        for <netdev@vger.kernel.org>; Mon, 14 May 2018 16:10:47 -0700 (PDT)
In-Reply-To: <c86a2fbde50aea2b28e82c333f29d575@codeaurora.org>
Content-Language: en-US
Sender: netdev-owner@vger.kernel.org
List-ID: <netdev.vger.kernel.org>



On 05/14/2018 03:45 PM, stranche@codeaurora.org wrote:
> On 2018-05-11 17:16, Willem de Bruijn wrote:
> 
>>> Hmm, no, we absolutely need to fix GSO instead.
>>>
>>> Think of a bonding device (or any virtual devices), your patch wont avoid the crash.
> 
> Hi Eric. Can you clarify what you mean by "fix GSO?" Is that just having the GSO path work
> regardless of whether or not SG is enabled for the device?
>

Yes. GSO is a fallback, and must work all the time, not panic.