From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 50E47C43387 for ; Thu, 17 Jan 2019 19:07:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1143620657 for ; Thu, 17 Jan 2019 19:07:05 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="C+cfFD+Q" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727528AbfAQTHE (ORCPT ); Thu, 17 Jan 2019 14:07:04 -0500 Received: from mail-pg1-f195.google.com ([209.85.215.195]:43005 "EHLO mail-pg1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726099AbfAQTHD (ORCPT ); Thu, 17 Jan 2019 14:07:03 -0500 Received: by mail-pg1-f195.google.com with SMTP id d72so4837353pga.9 for ; Thu, 17 Jan 2019 11:07:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:openpgp:autocrypt:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vjABM0ycn2BmxOVUkeeQaD965Q7uKR7gaRBn4yHnnC4=; b=C+cfFD+QhYGRFe+jCu6f+W/Jn/m+dnR5hJuw039/pAp5LltIs5BoGFi1BIbMRPqhDS JQBkdeBHFQYb/oO1xqT3t4rNq6ejkuz3shr/q3lXbJ6ciMAXicBOioAxoG5I3bG5+mCn pNq63RRd/oYEeVL69JFkmpnGL+/ArTMvHcpyE7tiMEsyjEWSLbCMK1XjsHT1Sqne/Qar o7PNJAXCLIKpEbaGzi4SDMO8KrpM1MtdWSUQp3v1Pqip+OPkJYXs0idc17Hr7patiSDe HBQNpMKAdsFCoUa33DvxnO2uNb/GpfS4b5r32wsr2DXYs4dX5Gz8FeqjFjZMUHYFxSzz AmMw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=vjABM0ycn2BmxOVUkeeQaD965Q7uKR7gaRBn4yHnnC4=; b=P/R2JjLX0GQW6HFOeUSVEJdUxdpKQZbGa7ueBLyUYwvUqwOQkNnk79PgNTTLqSxzdZ oOsow6O3AZ0bLXFLFSbOvnvoByYgEndygEZcDokuKwMfNRW8j58ZXPL3zEVJ9i6tXI5k Km+8cxiG5nOJ5bUTuM2XD35oMZL1GIOXCVZpY0qR9zJmHaV6tti1DQeRHWsVrtrbNDYV 1+Prc7PxSC9UhYaChmMiTuwan6Fu2iX53B1AE8v0xffrRb0Lgn+l90mrxS1gJex8Vg3T zINdSj7KMcdqQZhSz1hJO1rb69ANHFibMWxYdIJUMRSp3URqmOBAuWyqQ7XNLJy8eG7O 4JlQ== X-Gm-Message-State: AJcUukckvLrqzvXbOkpInTkdgXU8Aeegex76lSzJ3ehE8mBblpdNt6Bb 6rtm3rf4VgSsAqbkAVMCbGA= X-Google-Smtp-Source: ALg8bN4PxtsOh/8Sci1CdDS5ZoIG+j7eM/UAD8PrE850GYle7/0Md80e91eaiybP1HvwVUhHQVwU4A== X-Received: by 2002:a63:5346:: with SMTP id t6mr14762241pgl.40.1547752021806; Thu, 17 Jan 2019 11:07:01 -0800 (PST) Received: from [10.67.49.9] ([192.19.223.250]) by smtp.googlemail.com with ESMTPSA id u70sm4545808pfa.176.2019.01.17.11.07.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 17 Jan 2019 11:07:00 -0800 (PST) Subject: Re: [PATCH net-next 03/14] net: dsa: b53: Properly account for VLAN filtering To: Vivien Didelot Cc: netdev@vger.kernel.org, andrew@lunn.ch, davem@davemloft.net, idosch@mellanox.com, jiri@mellanox.com, ilias.apalodimas@linaro.org, ivan.khoronzhuk@linaro.org, roopa@cumulusnetworks.com, nikolay@cumulusnetworks.com References: <20190116200102.2749-1-f.fainelli@gmail.com> <20190116200102.2749-4-f.fainelli@gmail.com> <20190117113647.GF13242@t480s.localdomain> <0ee886f1-74cc-fe06-eca1-6567855785da@gmail.com> <20190117134755.GJ13242@t480s.localdomain> From: Florian Fainelli Openpgp: preference=signencrypt Autocrypt: addr=f.fainelli@gmail.com; prefer-encrypt=mutual; keydata= mQGiBEjPuBIRBACW9MxSJU9fvEOCTnRNqG/13rAGsj+vJqontvoDSNxRgmafP8d3nesnqPyR xGlkaOSDuu09rxuW+69Y2f1TzjFuGpBk4ysWOR85O2Nx8AJ6fYGCoeTbovrNlGT1M9obSFGQ X3IzRnWoqlfudjTO5TKoqkbOgpYqIo5n1QbEjCCwCwCg3DOH/4ug2AUUlcIT9/l3pGvoRJ0E AICDzi3l7pmC5IWn2n1mvP5247urtHFs/uusE827DDj3K8Upn2vYiOFMBhGsxAk6YKV6IP0d ZdWX6fqkJJlu9cSDvWtO1hXeHIfQIE/xcqvlRH783KrihLcsmnBqOiS6rJDO2x1eAgC8meAX SAgsrBhcgGl2Rl5gh/jkeA5ykwbxA/9u1eEuL70Qzt5APJmqVXR+kWvrqdBVPoUNy/tQ8mYc nzJJ63ng3tHhnwHXZOu8hL4nqwlYHRa9eeglXYhBqja4ZvIvCEqSmEukfivk+DlIgVoOAJbh qIWgvr3SIEuR6ayY3f5j0f2ejUMYlYYnKdiHXFlF9uXm1ELrb0YX4GMHz7QnRmxvcmlhbiBG YWluZWxsaSA8Zi5mYWluZWxsaUBnbWFpbC5jb20+iGYEExECACYCGyMGCwkIBwMCBBUCCAME FgIDAQIeAQIXgAUCVF/S8QUJHlwd3wAKCRBhV5kVtWN2DvCVAJ4u4/bPF4P3jxb4qEY8I2gS 6hG0gACffNWlqJ2T4wSSn+3o7CCZNd7SLSC5BA0ESM+4EhAQAL/o09boR9D3Vk1Tt7+gpYr3 WQ6hgYVON905q2ndEoA2J0dQxJNRw3snabHDDzQBAcqOvdi7YidfBVdKi0wxHhSuRBfuOppu pdXkb7zxuPQuSveCLqqZWRQ+Cc2QgF7SBqgznbe6Ngout5qXY5Dcagk9LqFNGhJQzUGHAsIs hap1f0B1PoUyUNeEInV98D8Xd/edM3mhO9nRpUXRK9Bvt4iEZUXGuVtZLT52nK6Wv2EZ1TiT OiqZlf1P+vxYLBx9eKmabPdm3yjalhY8yr1S1vL0gSA/C6W1o/TowdieF1rWN/MYHlkpyj9c Rpc281gAO0AP3V1G00YzBEdYyi0gaJbCEQnq8Vz1vDXFxHzyhgGz7umBsVKmYwZgA8DrrB0M oaP35wuGR3RJcaG30AnJpEDkBYHznI2apxdcuTPOHZyEilIRrBGzDwGtAhldzlBoBwE3Z3MY 31TOpACu1ZpNOMysZ6xiE35pWkwc0KYm4hJA5GFfmWSN6DniimW3pmdDIiw4Ifcx8b3mFrRO BbDIW13E51j9RjbO/nAaK9ndZ5LRO1B/8Fwat7bLzmsCiEXOJY7NNpIEpkoNoEUfCcZwmLrU +eOTPzaF6drw6ayewEi5yzPg3TAT6FV3oBsNg3xlwU0gPK3v6gYPX5w9+ovPZ1/qqNfOrbsE FRuiSVsZQ5s3AAMFD/9XjlnnVDh9GX/r/6hjmr4U9tEsM+VQXaVXqZuHKaSmojOLUCP/YVQo 7IiYaNssCS4FCPe4yrL4FJJfJAsbeyDykMN7wAnBcOkbZ9BPJPNCbqU6dowLOiy8AuTYQ48m vIyQ4Ijnb6GTrtxIUDQeOBNuQC/gyyx3nbL/lVlHbxr4tb6YkhkO6shjXhQh7nQb33FjGO4P WU11Nr9i/qoV8QCo12MQEo244RRA6VMud06y/E449rWZFSTwGqb0FS0seTcYNvxt8PB2izX+ HZA8SL54j479ubxhfuoTu5nXdtFYFj5Lj5x34LKPx7MpgAmj0H7SDhpFWF2FzcC1bjiW9mjW HaKaX23Awt97AqQZXegbfkJwX2Y53ufq8Np3e1542lh3/mpiGSilCsaTahEGrHK+lIusl6mz Joil+u3k01ofvJMK0ZdzGUZ/aPMZ16LofjFA+MNxWrZFrkYmiGdv+LG45zSlZyIvzSiG2lKy kuVag+IijCIom78P9jRtB1q1Q5lwZp2TLAJlz92DmFwBg1hyFzwDADjZ2nrDxKUiybXIgZp9 aU2d++ptEGCVJOfEW4qpWCCLPbOT7XBr+g/4H3qWbs3j/cDDq7LuVYIe+wchy/iXEJaQVeTC y5arMQorqTFWlEOgRA8OP47L9knl9i4xuR0euV6DChDrguup2aJVU4hPBBgRAgAPAhsMBQJU X9LxBQkeXB3fAAoJEGFXmRW1Y3YOj4UAn3nrFLPZekMeqX5aD/aq/dsbXSfyAKC45Go0YyxV HGuUuzv+GKZ6nsysJ7kCDQRXG8fwARAA6q/pqBi5PjHcOAUgk2/2LR5LjjesK50bCaD4JuNc YDhFR7Vs108diBtsho3w8WRd9viOqDrhLJTroVckkk74OY8r+3t1E0Dd4wHWHQZsAeUvOwDM PQMqTUBFuMi6ydzTZpFA2wBR9x6ofl8Ax+zaGBcFrRlQnhsuXLnM1uuvS39+pmzIjasZBP2H UPk5ifigXcpelKmj6iskP3c8QN6x6GjUSmYx+xUfs/GNVSU1XOZn61wgPDbgINJd/THGdqiO iJxCLuTMqlSsmh1+E1dSdfYkCb93R/0ZHvMKWlAx7MnaFgBfsG8FqNtZu3PCLfizyVYYjXbV WO1A23riZKqwrSJAATo5iTS65BuYxrFsFNPrf7TitM8E76BEBZk0OZBvZxMuOs6Z1qI8YKVK UrHVGFq3NbuPWCdRul9SX3VfOunr9Gv0GABnJ0ET+K7nspax0xqq7zgnM71QEaiaH17IFYGS sG34V7Wo3vyQzsk7qLf9Ajno0DhJ+VX43g8+AjxOMNVrGCt9RNXSBVpyv2AMTlWCdJ5KI6V4 KEzWM4HJm7QlNKE6RPoBxJVbSQLPd9St3h7mxLcne4l7NK9eNgNnneT7QZL8fL//s9K8Ns1W t60uQNYvbhKDG7+/yLcmJgjF74XkGvxCmTA1rW2bsUriM533nG9gAOUFQjURkwI8jvMAEQEA AYkCaAQYEQIACQUCVxvH8AIbAgIpCRBhV5kVtWN2DsFdIAQZAQIABgUCVxvH8AAKCRCH0Jac RAcHBIkHD/9nmfog7X2ZXMzL9ktT++7x+W/QBrSTCTmq8PK+69+INN1ZDOrY8uz6htfTLV9+ e2W6G8/7zIvODuHk7r+yQ585XbplgP0V5Xc8iBHdBgXbqnY5zBrcH+Q/oQ2STalEvaGHqNoD UGyLQ/fiKoLZTPMur57Fy1c9rTuKiSdMgnT0FPfWVDfpR2Ds0gpqWePlRuRGOoCln5GnREA/ 2MW2rWf+CO9kbIR+66j8b4RUJqIK3dWn9xbENh/aqxfonGTCZQ2zC4sLd25DQA4w1itPo+f5 V/SQxuhnlQkTOCdJ7b/mby/pNRz1lsLkjnXueLILj7gNjwTabZXYtL16z24qkDTI1x3g98R/ xunb3/fQwR8FY5/zRvXJq5us/nLvIvOmVwZFkwXc+AF+LSIajqQz9XbXeIP/BDjlBNXRZNdo dVuSU51ENcMcilPr2EUnqEAqeczsCGpnvRCLfVQeSZr2L9N4svNhhfPOEscYhhpHTh0VPyxI pPBNKq+byuYPMyk3nj814NKhImK0O4gTyCK9b+gZAVvQcYAXvSouCnTZeJRrNHJFTgTgu6E0 caxTGgc5zzQHeX67eMzrGomG3ZnIxmd1sAbgvJUDaD2GrYlulfwGWwWyTNbWRvMighVdPkSF 6XFgQaosWxkV0OELLy2N485YrTr2Uq64VKyxpncLh50e2RnyAJ9Za0Dx0yyp44iD1OvHtkEI M5kY0ACeNhCZJvZ5g4C2Lc9fcTHu8jxmEkI= Message-ID: <4d2fbe46-0675-a0b3-0cdb-c34e8bc9147a@gmail.com> Date: Thu, 17 Jan 2019 11:06:54 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <20190117134755.GJ13242@t480s.localdomain> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 1/17/19 10:47 AM, Vivien Didelot wrote: > On Thu, 17 Jan 2019 09:48:53 -0800, Florian Fainelli wrote: >> On 1/17/19 8:36 AM, Vivien Didelot wrote: >>> Hi Florian, >>> >>> On Wed, 16 Jan 2019 12:00:51 -0800, Florian Fainelli wrote: >>> >>>> + /* Handle the case were multiple bridges span the same switch device >>>> + * and one of them has a different setting than what is being requested >>>> + * which would be breaking filtering semantics for any of the other >>>> + * bridge devices. >>>> + */ >>>> + b53_for_each_port(dev, i) { >>>> + bridge_dev = dsa_to_port(ds, i)->bridge_dev; >>>> + if (bridge_dev && >>>> + bridge_dev != dsa_to_port(ds, port)->bridge_dev && >>>> + br_vlan_enabled(bridge_dev) != vlan_filtering) { >>>> + netdev_err(bridge_dev, >>>> + "VLAN filtering is global to the switch!\n"); >>>> + return -EINVAL; >>>> + } >>>> + } >>> >>> Unbridged ports must act as standard NICs and thus forward taggued frames. >>> What happens to them if there's a bridge with VLAN filtering enabled spawned >>> on other ports of your switch? Will the unbridged ports filter VLAN? >> Because VLAN filtering a global setting to the switch, unbridged network >> ports will effectively have VLAN filtering enabled, which is why the >> ndo_vlan_rx_{add,kill}_vid functions to permit that use case. > > But then vlan_filtering must simply not be allowed on your switch if you > have unbridged ports, no? VLAN filtering is an attribute that applies to the bridge, not the non-bridged network ports. > > I might be mixing things up here but I don't understand yet how you can > have bridged and unbridged ports working correctly on your switch when it > has global VLAN filtering turned on. I understand that the switch will drop > the tagged frames on ingress. With ndo_vlan_rx_{add,kill}_vid(), you get proper VLAN entries programmed into the switch for non-bridged ports, therefore your switch can allow VLAN tagged traffic (which these interfaces only support) just fine, even when a bridge has VLAN filtering turned on on a bridge device that has other switch ports enslaved. -- Florian