From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [iproute PATCH v3 0/6] Big C99 style initializer rework Date: Tue, 28 Jun 2016 11:59:04 -0600 Message-ID: <4d5a2616-d5cb-ad3f-e346-a24acc6879aa@cumulusnetworks.com> References: <20160627105912.7961c3f4@xeon-e3> <20160627182302.GB13664@orbyte.nwl.cc> <20160627141049.356c1eff@xeon-e3> <20160628173723.GA6733@orbyte.nwl.cc> <0a003d6f-ae2f-57cb-f3f1-1975011c7b78@cumulusnetworks.com> <20160628175835.GB6733@orbyte.nwl.cc> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit To: Phil Sutter , Stephen Hemminger , Daniel Borkmann , Nicolas Dichtel , Julien Floret , "netdev@vger.kernel.org" Return-path: Received: from mail-pa0-f47.google.com ([209.85.220.47]:33472 "EHLO mail-pa0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751158AbcF1R7F (ORCPT ); Tue, 28 Jun 2016 13:59:05 -0400 Received: by mail-pa0-f47.google.com with SMTP id b13so8604022pat.0 for ; Tue, 28 Jun 2016 10:59:05 -0700 (PDT) In-Reply-To: <20160628175835.GB6733@orbyte.nwl.cc> Sender: netdev-owner@vger.kernel.org List-ID: On 6/28/16 11:58 AM, Phil Sutter wrote: >> since .ifr_qlen is already referenced in that function seems like your >> suggestion above (struct ifreq ifr = { .ifr_qlen = 0 };) should be >> acceptable. > > You mean regarding compatibility of using that define? Or are you > concerned with gcc creating suboptimal code? no, I was thinking in terms of open coding knowledge of a struct. > I'd rather use a more generic approach than the above. Retrospectively, > I'd rather have that brace orgy instead of the above since it's > intention is more clear and it can be dropped once either gcc guys > manage to backport their fix or the last distribution has updated it's > compiler. ha, that's funny.