[PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Woojung.Huh]

From: Woojung Huh <Woojung.Huh@microchip.com>

Adding Microchip 9477 Phy included in KSZ9477 Switch.

Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
Signed-off-by: Andrew Lunn <andrew@lunn.ch>
---
 drivers/net/phy/micrel.c   | 11 +++++++++++
 include/linux/micrel_phy.h |  2 ++
 2 files changed, 13 insertions(+)

diff --git a/drivers/net/phy/micrel.c b/drivers/net/phy/micrel.c
index 4cfd541..46e80bc 100644
--- a/drivers/net/phy/micrel.c
+++ b/drivers/net/phy/micrel.c
@@ -20,6 +20,7 @@
  *			   ksz8081, ksz8091,
  *			   ksz8061,
  *		Switch : ksz8873, ksz886x
+ *			 ksz9477
  */
 
 #include <linux/kernel.h>
@@ -996,6 +997,16 @@ static struct phy_driver ksphy_driver[] = {
 	.read_status	= ksz8873mll_read_status,
 	.suspend	= genphy_suspend,
 	.resume		= genphy_resume,
+}, {
+	.phy_id		= PHY_ID_KSZ9477,
+	.phy_id_mask	= MICREL_PHY_ID_MASK,
+	.name		= "Microchip KSZ9477",
+	.features	= PHY_GBIT_FEATURES,
+	.config_init	= kszphy_config_init,
+	.config_aneg	= genphy_config_aneg,
+	.read_status	= genphy_read_status,
+	.suspend	= genphy_suspend,
+	.resume		= genphy_resume,
 } };
 
 module_phy_driver(ksphy_driver);
diff --git a/include/linux/micrel_phy.h b/include/linux/micrel_phy.h
index f541da6..472fa4d 100644
--- a/include/linux/micrel_phy.h
+++ b/include/linux/micrel_phy.h
@@ -37,6 +37,8 @@
 
 #define PHY_ID_KSZ8795		0x00221550
 
+#define	PHY_ID_KSZ9477		0x00221631
+
 /* struct phy_device dev_flags definitions */
 #define MICREL_PHY_50MHZ_CLK	0x00000001
 #define MICREL_PHY_FXEN		0x00000002
-- 
2.7.4

Re: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Florian Fainelli]

On 05/19/2017 03:57 PM, Woojung.Huh@microchip.com wrote:
> From: Woojung Huh <Woojung.Huh@microchip.com>
> 
> Adding Microchip 9477 Phy included in KSZ9477 Switch.
> 
> Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
-- 
Florian

Re: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Andrew Lunn]

On Fri, May 19, 2017 at 10:57:15PM +0000, Woojung.Huh@microchip.com wrote:
> From: Woojung Huh <Woojung.Huh@microchip.com>
> 
> Adding Microchip 9477 Phy included in KSZ9477 Switch.
> 
> Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> Signed-off-by: Andrew Lunn <andrew@lunn.ch>

Signed-off-by? I didn't contribute any code. It probably should be

Reviewed-by: Andrew Lunn <andrew@lunn.ch>

    Andrew

RE: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Woojung.Huh]

> > Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> 
> Signed-off-by? I didn't contribute any code. It probably should be
> 
> Reviewed-by: Andrew Lunn <andrew@lunn.ch>
Andrew,

Your reply on 5/13 was with "Signed-off" :)
Will change to "Reviewed-by" in next patch.

Woojung

Re: [PATCH v3 net-next 2/5] phy: micrel: add Microchip KSZ 9477 Switch PHY support

[Andrew Lunn]

On Mon, May 22, 2017 at 02:38:39PM +0000, Woojung.Huh@microchip.com wrote:
> > > Signed-off-by: Woojung Huh <Woojung.Huh@microchip.com>
> > > Signed-off-by: Andrew Lunn <andrew@lunn.ch>
> > 
> > Signed-off-by? I didn't contribute any code. It probably should be
> > 
> > Reviewed-by: Andrew Lunn <andrew@lunn.ch>
> Andrew,
> 
> Your reply on 5/13 was with "Signed-off" :)

O.K. My error then. Please feel free at ask me, if you think something
i say is wrong...

> Will change to "Reviewed-by" in next patch.

Thanks.

	Andrew