From mboxrd@z Thu Jan 1 00:00:00 1970 From: Florian Fainelli Subject: Re: [PATCH net-next] net: phy: mscc: the extended page access register is 16 bits Date: Mon, 30 Jul 2018 09:53:31 -0700 Message-ID: <4dd7d451-a1e3-cab8-dc5a-6666c5d29089@gmail.com> References: <20180730125313.3405-1-quentin.schulz@bootlin.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: netdev@vger.kernel.org, alexandre.belloni@bootlin.com, linux-kernel@vger.kernel.org, thomas.petazzoni@bootlin.com To: Quentin Schulz , andrew@lunn.ch, davem@davemloft.net Return-path: In-Reply-To: <20180730125313.3405-1-quentin.schulz@bootlin.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-Id: netdev.vger.kernel.org On 07/30/2018 05:53 AM, Quentin Schulz wrote: > The Extended Page Access is a 16-bit register, so change the page > parameter of vsc85xx_phy_page_set to a u16. > > Signed-off-by: Quentin Schulz Since you targeted net-next for this patch, I am assuming this is not yet a problem, but would soon be one with the changes you plan on introducing? > --- > drivers/net/phy/mscc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/phy/mscc.c b/drivers/net/phy/mscc.c > index 650c2667d523..84ca9ff40ae0 100644 > --- a/drivers/net/phy/mscc.c > +++ b/drivers/net/phy/mscc.c > @@ -123,7 +123,7 @@ static const struct vsc8531_edge_rate_table edge_table[] = { > }; > #endif /* CONFIG_OF_MDIO */ > > -static int vsc85xx_phy_page_set(struct phy_device *phydev, u8 page) > +static int vsc85xx_phy_page_set(struct phy_device *phydev, u16 page) > { > int rc; > > -- Florian