From: Eric Dumazet <eric.dumazet@gmail.com>
To: David Miller <davem@davemloft.net>, lirongqing@baidu.com
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS
Date: Sat, 7 Jul 2018 17:22:01 -0700 [thread overview]
Message-ID: <4df439f1-d80c-a2ff-d1ac-d5475694a59e@gmail.com> (raw)
In-Reply-To: <20180705.192035.695280292431389546.davem@davemloft.net>
On 07/05/2018 03:20 AM, David Miller wrote:
> From: Li RongQing <lirongqing@baidu.com>
> Date: Thu, 5 Jul 2018 14:34:32 +0800
>
>> After commit 07d78363dcff ("net: Convert NAPI gro list into a small hash
>> table.")' there is 8 hash buckets, which allows more flows to be held for
>> merging. but MAX_GRO_SKBS, the total held skb for merging, is 8 skb still,
>> limit the hash table performance.
>>
>> keep MAX_GRO_SKBS as 8 skb, but limit each hash list length to 8 skb, not
>> the total 8 skb
>>
>> Signed-off-by: Li RongQing <lirongqing@baidu.com>
>
> Applied, thanks.
>
Maybe gro_count should be replaced by a bitmask, so that we can speed up
napi_gro_flush(), since it now has to use 3 cache lines (gro_hash[] size is 192 bytes)
next prev parent reply other threads:[~2018-07-08 0:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-05 6:34 [PATCH][net-next][v2] net: limit each hash list length to MAX_GRO_SKBS Li RongQing
2018-07-05 10:20 ` David Miller
2018-07-08 0:22 ` Eric Dumazet [this message]
2018-07-08 1:32 ` David Miller
2018-07-10 10:59 ` 答复: " Li,Rongqing
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4df439f1-d80c-a2ff-d1ac-d5475694a59e@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=lirongqing@baidu.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).