From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=/nVN=5T=vger.kernel.org=netdev-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id 998DEC43331
	for <netdev@archiver.kernel.org>; Fri,  3 Apr 2020 21:12:04 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 6670E20737
	for <netdev@archiver.kernel.org>; Fri,  3 Apr 2020 21:12:04 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728249AbgDCVMD (ORCPT <rfc822;netdev@archiver.kernel.org>);
        Fri, 3 Apr 2020 17:12:03 -0400
Received: from smtprelay0230.hostedemail.com ([216.40.44.230]:43110 "EHLO
        smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL)
        by vger.kernel.org with ESMTP id S1728173AbgDCVMD (ORCPT
        <rfc822;netdev@vger.kernel.org>); Fri, 3 Apr 2020 17:12:03 -0400
Received: from filter.hostedemail.com (clb03-v110.bra.tucows.net [216.40.38.60])
        by smtprelay05.hostedemail.com (Postfix) with ESMTP id DBC401803F787;
        Fri,  3 Apr 2020 21:12:01 +0000 (UTC)
X-Session-Marker: 6A6F6540706572636865732E636F6D
X-HE-Tag: woman60_2ea71f4a1b319
X-Filterd-Recvd-Size: 1298
Received: from XPS-9350.home (unknown [47.151.136.130])
        (Authenticated sender: joe@perches.com)
        by omf15.hostedemail.com (Postfix) with ESMTPA;
        Fri,  3 Apr 2020 21:12:00 +0000 (UTC)
Message-ID: <4e26a79ed71bd41b3bf2f65e48c4e4c41094fddc.camel@perches.com>
Subject: Re: question about drivers/net/dsa/sja1105/sja1105_main.c
From:   Joe Perches <joe@perches.com>
To:     Heiner Kallweit <hkallweit1@gmail.com>,
        Vladimir Oltean <olteanv@gmail.com>,
        Julia Lawall <julia.lawall@inria.fr>
Cc:     netdev <netdev@vger.kernel.org>,
        Russell King - ARM Linux admin <linux@armlinux.org.uk>,
        Andrew Lunn <andrew@lunn.ch>,
        Florian Fainelli <f.fainelli@gmail.com>
Date:   Fri, 03 Apr 2020 14:10:03 -0700
In-Reply-To: <7fc8f8d5-285a-9ec0-23c5-c867347c4feb@gmail.com>
References: <alpine.DEB.2.21.2004031542220.2694@hadrien>
         <CA+h21hrP-0Tdpqje-xbPHmh+v+zndsFyxaEfadMwdAHY+9QK+g@mail.gmail.com>
         <7fc8f8d5-285a-9ec0-23c5-c867347c4feb@gmail.com>
Content-Type: text/plain; charset="ISO-8859-1"
User-Agent: Evolution 3.34.1-2 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: netdev-owner@vger.kernel.org
Precedence: bulk
List-ID: <netdev.vger.kernel.org>
X-Mailing-List: netdev@vger.kernel.org

On Fri, 2020-04-03 at 23:02 +0200, Heiner Kallweit wrote:
> It's right that this is not correct. You can check genphy_read_status_fixed()
> for how it's done there.

There is no SPEED_UNKNOWN in that function.