From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0AC8BC32771 for ; Tue, 16 Aug 2022 10:46:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233830AbiHPKqW (ORCPT ); Tue, 16 Aug 2022 06:46:22 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235027AbiHPKpJ (ORCPT ); Tue, 16 Aug 2022 06:45:09 -0400 Received: from www62.your-server.de (www62.your-server.de [213.133.104.62]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id A838852DCB; Tue, 16 Aug 2022 02:54:39 -0700 (PDT) Received: from sslproxy06.your-server.de ([78.46.172.3]) by www62.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92.3) (envelope-from ) id 1oNtHL-0008sY-GS; Tue, 16 Aug 2022 11:54:31 +0200 Received: from [85.1.206.226] (helo=linux-4.home) by sslproxy06.your-server.de with esmtpsa (TLSv1.3:TLS_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1oNtHL-000Bt7-6s; Tue, 16 Aug 2022 11:54:31 +0200 Subject: Re: [PATCH bpf-next] xdp: report rx queue index in xdp_frame To: Lorenzo Bianconi , Lorenzo Bianconi Cc: bpf@vger.kernel.org, ast@kernel.org, andrii@kernel.org, netdev@vger.kernel.org, davem@davemloft.net, kuba@kernel.org, edumazet@google.com, pabeni@redhat.com, hawk@kernel.org, john.fastabend@gmail.com References: <181f994e13c816116fa69a1e92c2f69e6330f749.1658746417.git.lorenzo@kernel.org> From: Daniel Borkmann Message-ID: <4e717cbe-17a2-dbae-d557-0b29eaa28dae@iogearbox.net> Date: Tue, 16 Aug 2022 11:54:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.2 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=windows-1252; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Authenticated-Sender: daniel@iogearbox.net X-Virus-Scanned: Clear (ClamAV 0.103.6/26629/Tue Aug 16 09:51:41 2022) Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 8/16/22 11:45 AM, Lorenzo Bianconi wrote: >> Report rx queue index in xdp_frame according to the xdp_buff xdp_rxq_info >> pointer. xdp_frame queue_index is currently used in cpumap code to covert >> the xdp_frame into a xdp_buff. >> xdp_frame size is not increased adding queue_index since an alignment padding >> in the structure is used to insert queue_index field. >> >> Signed-off-by: Lorenzo Bianconi >> --- >> include/net/xdp.h | 2 ++ >> kernel/bpf/cpumap.c | 2 +- >> 2 files changed, 3 insertions(+), 1 deletion(-) > > > Hi Alexei and Daniel, > > this patch is marked as 'new, archived' in patchwork. > Do I need to rebase and repost it? Yes, please rebase and resend. Perhaps also improve the commit description a bit in terms of what it fixes, it's a bit terse to the reader above on what effect it has. Thanks, Daniel