From: Nikolay Aleksandrov <razor@blackwall.org>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com, pabeni@redhat.com,
andrew+netdev@lunn.ch, horms@kernel.org, kernel@xen0n.name,
chenhuacai@kernel.org, tsbogend@alpha.franken.de, deller@gmx.de,
idosch@nvidia.com, aconole@redhat.com, ardb@kernel.org,
tim.bird@sony.com, loongarch@lists.linux.dev,
linux-mips@vger.kernel.org, linux-parisc@vger.kernel.org
Subject: Re: [PATCH net-next 0/3] net: move the type 2 sockets out of tree
Date: Wed, 30 Sep 2026 11:15:45 +0300 [thread overview]
Message-ID: <4e71fcfa-f733-4c4e-ab98-da8cd0531a02@blackwall.org> (raw)
In-Reply-To: <20260928190800.2521749-1-kuba@kernel.org>
On 28/09/2026 22:07, Jakub Kicinski wrote:
> LLC2 sockets are admin-only already. We have been getting a trickle
> of LLM-driven fixes for these, even tho we don't know of any active
> user. The code is so bad the LLM fixes just turn into a never ending
> stream of revisions and follow ups as fixing one condition reveals
> 5 more bugs. Let's move this code out of tree.
>
> The series itself is LLM generated, the LLM was also nice enough
> to generates some tests and validate that the OOT module actually
> works.
>
> Jakub Kicinski (3):
> llc: move the type 2 sockets out of tree
> llc: strip the leftovers of the llc2 removal
> net: drop unused LLC-related includes
>
> net/llc/Kconfig | 7 -
> net/llc/Makefile | 10 +-
> include/linux/llc.h | 5 -
> include/net/llc.h | 108 +-
> include/net/llc_c_ac.h | 180 -
> include/net/llc_c_ev.h | 217 -
> include/net/llc_c_st.h | 46 -
> include/net/llc_conn.h | 114 -
> include/net/llc_if.h | 63 -
> include/net/llc_pdu.h | 379 +-
> include/net/llc_s_ac.h | 35 -
> include/net/llc_s_ev.h | 61 -
> include/net/llc_s_st.h | 32 -
> include/net/llc_sap.h | 26 -
> net/802/garp.c | 4 +-
> net/802/psnap.c | 2 +-
> net/bridge/br.c | 2 -
> net/bridge/br_stp_bpdu.c | 3 +-
> net/llc/af_llc.c | 1304 -----
> net/llc/llc_c_ac.c | 1448 ------
> net/llc/llc_c_ev.c | 742 ---
> net/llc/llc_c_st.c | 4940 -------------------
> net/llc/llc_conn.c | 1025 ----
> net/llc/llc_core.c | 28 +-
> net/llc/llc_if.c | 151 -
> net/llc/llc_input.c | 128 +-
> net/llc/llc_output.c | 3 +-
> net/llc/llc_pdu.c | 366 --
> net/llc/llc_proc.c | 245 -
> net/llc/llc_s_ac.c | 220 -
> net/llc/llc_s_ev.c | 109 -
> net/llc/llc_s_st.c | 177 -
> net/llc/llc_sap.c | 437 --
> net/llc/llc_station.c | 120 -
> net/llc/sysctl_net_llc.c | 71 -
> net/openvswitch/flow.c | 1 -
> net/openvswitch/flow_netlink.c | 2 -
> net/openvswitch/flow_table.c | 2 -
> net/openvswitch/vport-netdev.c | 1 -
> arch/loongarch/configs/loongson32_defconfig | 1 -
> arch/loongarch/configs/loongson64_defconfig | 1 -
> arch/mips/configs/gpr_defconfig | 1 -
> arch/mips/configs/mtx1_defconfig | 1 -
> arch/mips/configs/rb532_defconfig | 1 -
> arch/parisc/configs/generic-32bit_defconfig | 1 -
> 45 files changed, 33 insertions(+), 12787 deletions(-)
> delete mode 100644 include/net/llc_c_ac.h
> delete mode 100644 include/net/llc_c_ev.h
> delete mode 100644 include/net/llc_c_st.h
> delete mode 100644 include/net/llc_conn.h
> delete mode 100644 include/net/llc_if.h
> delete mode 100644 include/net/llc_s_ac.h
> delete mode 100644 include/net/llc_s_ev.h
> delete mode 100644 include/net/llc_s_st.h
> delete mode 100644 include/net/llc_sap.h
> delete mode 100644 net/llc/af_llc.c
> delete mode 100644 net/llc/llc_c_ac.c
> delete mode 100644 net/llc/llc_c_ev.c
> delete mode 100644 net/llc/llc_c_st.c
> delete mode 100644 net/llc/llc_conn.c
> delete mode 100644 net/llc/llc_if.c
> delete mode 100644 net/llc/llc_pdu.c
> delete mode 100644 net/llc/llc_proc.c
> delete mode 100644 net/llc/llc_s_ac.c
> delete mode 100644 net/llc/llc_s_ev.c
> delete mode 100644 net/llc/llc_s_st.c
> delete mode 100644 net/llc/llc_sap.c
> delete mode 100644 net/llc/llc_station.c
> delete mode 100644 net/llc/sysctl_net_llc.c
>
Reviewed what I could, generally sounds good as well.
For the series:
Reviewed-by: Nikolay Aleksandrov <razor@blackwall.org>
next prev parent reply other threads:[~2026-09-30 8:15 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 19:07 [PATCH net-next 0/3] net: move the type 2 sockets out of tree Jakub Kicinski
2026-09-28 19:07 ` [PATCH net-next 1/3] llc: " Jakub Kicinski
2026-10-01 22:35 ` David Laight
2026-09-28 19:07 ` [PATCH net-next 2/3] llc: strip the leftovers of the llc2 removal Jakub Kicinski
2026-09-28 19:08 ` [PATCH net-next 3/3] net: drop unused LLC-related includes Jakub Kicinski
2026-09-29 14:11 ` Aaron Conole
2026-09-30 8:15 ` Nikolay Aleksandrov [this message]
2026-10-01 8:20 ` [PATCH net-next 0/3] net: move the type 2 sockets out of tree patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4e71fcfa-f733-4c4e-ab98-da8cd0531a02@blackwall.org \
--to=razor@blackwall.org \
--cc=aconole@redhat.com \
--cc=andrew+netdev@lunn.ch \
--cc=ardb@kernel.org \
--cc=chenhuacai@kernel.org \
--cc=davem@davemloft.net \
--cc=deller@gmx.de \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=idosch@nvidia.com \
--cc=kernel@xen0n.name \
--cc=kuba@kernel.org \
--cc=linux-mips@vger.kernel.org \
--cc=linux-parisc@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tim.bird@sony.com \
--cc=tsbogend@alpha.franken.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox