From mboxrd@z Thu Jan 1 00:00:00 1970 From: David Ahern Subject: Re: [PATCH net] udp: fix SO_BINDTODEVICE Date: Wed, 9 May 2018 09:18:32 -0600 Message-ID: <4e7b728a-2657-b171-e02b-81e7a9443c6a@gmail.com> References: <9445dd5d149af16463df4d0502b2667ee2b6f4e8.1525862461.git.pabeni@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Cc: Damir Mansurov , David Miller To: Paolo Abeni , netdev@vger.kernel.org Return-path: Received: from mail-pf0-f193.google.com ([209.85.192.193]:38447 "EHLO mail-pf0-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935296AbeEIPSv (ORCPT ); Wed, 9 May 2018 11:18:51 -0400 Received: by mail-pf0-f193.google.com with SMTP id o76so25798499pfi.5 for ; Wed, 09 May 2018 08:18:51 -0700 (PDT) In-Reply-To: <9445dd5d149af16463df4d0502b2667ee2b6f4e8.1525862461.git.pabeni@redhat.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 5/9/18 4:42 AM, Paolo Abeni wrote: > Damir reported a breakage of SO_BINDTODEVICE for UDP sockets. > In absence of VRF devices, after commit fb74c27735f0 ("net: > ipv4: add second dif to udp socket lookups") the dif mismatch > isn't fatal anymore for UDP socket lookup with non null > sk_bound_dev_if, breaking SO_BINDTODEVICE semantics. > > This changeset addresses the issue making the dif match mandatory > again in the above scenario. > > Reported-by: Damir Mansurov > Fixes: fb74c27735f0 ("net: ipv4: add second dif to udp socket lookups") > Fixes: 1801b570dd2a ("net: ipv6: add second dif to udp socket lookups") > Signed-off-by: Paolo Abeni > --- > net/ipv4/udp.c | 4 ++-- > net/ipv6/udp.c | 4 ++-- > 2 files changed, 4 insertions(+), 4 deletions(-) > Acked-by: David Ahern