From mboxrd@z Thu Jan 1 00:00:00 1970 From: Eric Dumazet Subject: Re: [PATCH net-next v6] Add Common Applications Kept Enhanced (cake) qdisc Date: Tue, 1 May 2018 12:12:45 -0700 Message-ID: <4ec8da81-8671-f434-bada-27088b09ce7b@gmail.com> References: <20180429213439.7389-1-toke@toke.dk> <878t932ont.fsf@toke.dk> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Cc: Linux Kernel Network Developers , Cake List To: =?UTF-8?Q?Toke_H=c3=b8iland-J=c3=b8rgensen?= , Eric Dumazet , Dave Taht , Cong Wang Return-path: Received: from mail-pg0-f53.google.com ([74.125.83.53]:40085 "EHLO mail-pg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753505AbeEATMr (ORCPT ); Tue, 1 May 2018 15:12:47 -0400 Received: by mail-pg0-f53.google.com with SMTP id l2-v6so8873134pgc.7 for ; Tue, 01 May 2018 12:12:47 -0700 (PDT) In-Reply-To: <878t932ont.fsf@toke.dk> Content-Language: en-US Sender: netdev-owner@vger.kernel.org List-ID: On 05/01/2018 11:53 AM, Toke Høiland-Jørgensen wrote: > *sigh* - can do, I guess. Though I'm not sure what that is going to > accomplish, exactly? I guess that nobody really wants to really review Cake if it is a file with 2700 lines of code and hundreds of variables/tunables. Sure, we have big files in networking land, as a result of thousands of changes. If you split it, then maybe the work can be split among reviewers as a result. Or maybe David Miller can simply merge your patch as is, and hope for the best, I really do not know. It seems you guys spent years/months on work on this stuff, so what is the big deal about presenting your work in the best possible way ? Thanks.