From: David Ahern <dsahern@gmail.com>
To: Jiri Pirko <jiri@resnulli.us>
Cc: netdev@vger.kernel.org, davem@davemloft.net,
jakub.kicinski@netronome.com, stephen@networkplumber.org,
roopa@cumulusnetworks.com, dcbw@redhat.com,
nikolay@cumulusnetworks.com, mkubecek@suse.cz, andrew@lunn.ch,
parav@mellanox.com, saeedm@mellanox.com, f.fainelli@gmail.com,
sd@queasysnail.net, sbrivio@redhat.com, pabeni@redhat.com,
mlxsw@mellanox.com
Subject: Re: [patch iproute2-next v3 2/2] ip: allow to use alternative names as handle
Date: Thu, 17 Oct 2019 11:34:54 -0400 [thread overview]
Message-ID: <4ed31257-a1d1-23a3-827e-9dc1ec81ff26@gmail.com> (raw)
In-Reply-To: <20191016112858.GA2184@nanopsycho>
On 10/16/19 7:28 AM, Jiri Pirko wrote:
> Tue, Oct 15, 2019 at 08:34:56PM CEST, dsahern@gmail.com wrote:
>> On 10/9/19 8:49 AM, Jiri Pirko wrote:
>>> From: Jiri Pirko <jiri@mellanox.com>
>>>
>>> Extend ll_name_to_index() to get the index of a netdevice using
>>> alternative interface name. Allow alternative long names to pass checks
>>> in couple of ip link/addr commands.
>>
>> you don't add altnames to the name_hash, so the lookup can not find a
>> match based on altname.
>
> you are right, it is always going to fall back to ll_link_get(). I will
> do another patch to add the altnames to name_hash. It can go in
> separatelly or I can add that to this patchset. Up to you.
this patch claims to do the lookup, so it should actually be able to do
a lookup.
next prev parent reply other threads:[~2019-10-17 15:35 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-09 12:49 [patch iproute2-next v3 0/2] ip: add support for alternative names Jiri Pirko
2019-10-09 12:49 ` [patch iproute2-next v3 1/2] ip: add support for alternative name addition/deletion/list Jiri Pirko
2019-10-09 12:49 ` [patch iproute2-next v3 2/2] ip: allow to use alternative names as handle Jiri Pirko
2019-10-15 18:34 ` David Ahern
2019-10-16 11:28 ` Jiri Pirko
2019-10-17 15:34 ` David Ahern [this message]
2019-10-17 17:14 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ed31257-a1d1-23a3-827e-9dc1ec81ff26@gmail.com \
--to=dsahern@gmail.com \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dcbw@redhat.com \
--cc=f.fainelli@gmail.com \
--cc=jakub.kicinski@netronome.com \
--cc=jiri@resnulli.us \
--cc=mkubecek@suse.cz \
--cc=mlxsw@mellanox.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=pabeni@redhat.com \
--cc=parav@mellanox.com \
--cc=roopa@cumulusnetworks.com \
--cc=saeedm@mellanox.com \
--cc=sbrivio@redhat.com \
--cc=sd@queasysnail.net \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).