From: David Ahern <dsahern@gmail.com>
To: Kevin Darbyshire-Bryant <kevin@darbyshire-bryant.me.uk>,
Stephen Hemminger <stephen@networkplumber.org>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: Re: [PATCH] json_print: fix print_uint with helper type extensions
Date: Mon, 26 Mar 2018 09:03:38 -0600 [thread overview]
Message-ID: <4f02a767-abc6-4e04-22c1-fee79e1ac323@gmail.com> (raw)
In-Reply-To: <1BC918EA-5B3E-41D7-B033-AC659B615829@darbyshire-bryant.me.uk>
On 3/18/18 2:40 AM, Kevin Darbyshire-Bryant wrote:
>
>
>> On 16 Mar 2018, at 20:34, Stephen Hemminger <stephen@networkplumber.org> wrote:
>>>
>>> print_uint64(PRINT_ANY, "refcnt", "refcnt %" PRIu64 " ", t->tcm_info)
>>>
>>> Signed-off-by: Kevin Darbyshire-Bryant <ldir@darbyshire-bryant.me.uk>
>>
>> I am fine with this. But since there is no code using it yet, it should
>> go net-next branch.
>>
>> Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
>
> Existing code is tripping up over the hidden uint - > uint64_t promotion in print_uint in iproute2 v4.15, that’s how I fell over the issue. Should I split the patch? One fixing the uint->uint64_t and the other offering the explicit type length options.
>
> Obviously I now realise that the email header should have iproute2 in it. Learning, slowly :-)
>
Kevin: I guess you need to split the patch. Extract the bug fix piece
and send for iproute2; enhancements go to iproute2-next.
next prev parent reply other threads:[~2018-03-26 15:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 20:07 [PATCH] json_print: fix print_uint with helper type extensions Kevin Darbyshire-Bryant
2018-03-16 20:34 ` Stephen Hemminger
2018-03-18 8:40 ` Kevin Darbyshire-Bryant
2018-03-26 15:03 ` David Ahern [this message]
2018-03-29 19:33 ` Kevin Darbyshire-Bryant
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f02a767-abc6-4e04-22c1-fee79e1ac323@gmail.com \
--to=dsahern@gmail.com \
--cc=kevin@darbyshire-bryant.me.uk \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox