From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 610E14C900C for ; Tue, 29 Sep 2026 08:59:56 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790672398; cv=none; b=BTKO/08p3AJGdA339azJEJ4XC52NXpb0n1MyaCBalzKZFzLGmPv9eHeqJypQj/wQNBe0HSEmZsTDEM/MKVsJlfuPkxlk5rJAXTMEv7JTGiI3BG8e7nyAhgsTKCwXRCypMsQtGGNzOe1SS0VBHT7gHejcpV8sODECHc5Tg7AlZII= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1790672398; c=relaxed/simple; bh=IyspYJuvnDQiFffor9pIZti6hii3F6jxoMPcS2SzFIU=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=iZCmkwssnkHyoXZNKO33gFfSwJ7ZdKMEKjo+j9Aaxfb42LnXUCkpxwlp6GnAp9MBZ8srVS+VVj3OJM9U346GwrkuFFf6UxzPqXj4AmzqkdjajqMwq6YjUsaMKXGM/xW2CsWtIkPZpgCMyDE33D8fwHZ/uEtqZJBfEDX+2tnfglM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=GAEVk6MU; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=IZmgmQCe; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="GAEVk6MU"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="IZmgmQCe" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1790672395; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/Y/oFOa1oxhQ1GdKVJmuNjJ216LwSgeUy79De2Uv5lM=; b=GAEVk6MUdaHD+woVWLegCArPhmc6TU7XFHJSFRwb6Sm9MztxdCzguw66O+CnASyOJ/PPGv w38SD/4POIKlc0Ew6WLqclG3CTuGFBoJ3Ty5azM15bc3GHjsPAxeJm1u2y+AelZ17Zh+tu nHw6cPhRLu2trkcRV3InP5GOKMqat3M= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-187-1tcGlfTkN0-_bfBl2UDmfQ-1; Tue, 29 Sep 2026 04:59:53 -0400 X-MC-Unique: 1tcGlfTkN0-_bfBl2UDmfQ-1 X-Mimecast-MFC-AGG-ID: 1tcGlfTkN0-_bfBl2UDmfQ_1790672393 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-49fcc575709so39479705e9.3 for ; Tue, 29 Sep 2026 01:59:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1790672392; x=1791277192; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:from:to:cc:subject:date:message-id:reply-to :content-type; bh=/Y/oFOa1oxhQ1GdKVJmuNjJ216LwSgeUy79De2Uv5lM=; b=IZmgmQCeFtm8hBMCzhd1u8jKfG2LubfFaxq+LRmLnOhkoCBczLZtRSn+Gj4YQg4ldv umvXBHWjYZFBW7JI5hbjKtgNdUzYYLscPdlAKNfHvLDy8scqAuAg3+SQFKojl7HJ3qOO nMVM6bPaXcZrpjQ3xftifPovQixQGVAmPZSj3pulwDC8ckHXd9hxKs1sw39ufmYddTvx jmoN5lFt5nuttTXRfzZ9MFdIchuTvpyRO3yUKFvjggXOoOfRkOdV7DDT7LlOnncA+86B DqrJD2R5PYDV85JHlYnpootF8/wF2J3ytevTLm+s9HZve+MyzE94d+WBfb3wJCQ4qlCI xqbA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1790672392; x=1791277192; h=content-transfer-encoding:content-type:in-reply-to:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to:content-type; bh=/Y/oFOa1oxhQ1GdKVJmuNjJ216LwSgeUy79De2Uv5lM=; b=0F55im1n5YDhgQ8KMpop/XttbXpcpyQd7Dl2n2kMYmP5KKQoiJ6jkFO0dG615aw0CA uSmtMuwn78fJZ0GwYmKgALK8RzEF2oKB6/Yojln16sZ3vB8oQH4WwZGrgdKjw453u5wW cAFuM8vltuhoAv09M12nPYvqjVyv3gltZGDYdMb6mbpZDW9kT8P7iQDwfclqRc9p98me AZDs5kr6sj2KqZ9BEILuWl0LO8ar+LeKB4lHvj7TqwxLDH4eFxPlfwq3R1WRWY+RmS+l q63XNYkE3Eo6dxTrjLNbv/h8GlmSD9cK1geFiFT9QxF7zR92vK4e5e6KMmLBwVtmFyzt Skkw== X-Forwarded-Encrypted: i=1; AKwUvBwY0QGm2KfQI2rtH2wEzvAX3RaRMTDE3pRmCrKLyojdtgkNOyBFBxEvJT4mk9PcPBiyxz+zAVA=@vger.kernel.org X-Gm-Message-State: AFuF++kQzl6n5HLmKw2RiPgvT7UPfYfZZivMRp+nAKdvWpNwOBhRAGrx 1gt2j2ivWZFcSmMSkvdK6vcdrVchQPXirMDPoXSlq76mxfqxdInIsRJxG3MeoWW/O5wNDaIFe6O 7KLNzkZtEGbjbuVUOXPrUC4R+10djktzhFHUmoRGzSRa3rmvvkWPyVl9HsA== X-Gm-Gg: AYBFou0eYXG9E9xBybTdbkYWV+4mnORgdrCe/2J2PYOBpxtCip+SjSjZ4AMV4RB47Mg Sj7qXzYhVW6WZoGh4bTayPuuZA+4+RLbGbMqcxuo/8/ZcPYUtbuzOGx/kFEftPrhM7un6jaDtRw pDTMG1rc8FBSsIggmm9c4NBLYngjPwAom/8YU8E3cMwauHUwSnqPCkoxgoaeLa5kxXVm9CFU0ru Tu85RPSXGbCnLIpEnGnE2JuB3Li5QW0NDUVwV3eQbtRZ/b7ViserQ3VlFpJRWdiCllbZ26+N2yA XKKcECa/kENE24u14XJMDHd6StLaiXjToQQkz4J9JNU2ufO9e85b6M0llhgcOpob5y3BVd5cCo+ RR4PfWB2wtNAUjg9a/P/bi5ymvsXvjAGsbTogBSJvQSk7Cg+pb/4Yh6MWWvrkX7ztlg+bjzv4+g == X-Received: by 2002:a05:600c:8b33:b0:49f:f9fa:fcfe with SMTP id 5b1f17b1804b1-49ff9fafdccmr148517455e9.13.1790672392630; Tue, 29 Sep 2026 01:59:52 -0700 (PDT) X-Received: by 2002:a05:600c:8b33:b0:49f:f9fa:fcfe with SMTP id 5b1f17b1804b1-49ff9fafdccmr148516975e9.13.1790672392160; Tue, 29 Sep 2026 01:59:52 -0700 (PDT) Received: from [192.168.188.234] (ip232-47-231-195.pool-bba.aruba.it. [195.231.47.232]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4a00cfec770sm65459555e9.8.2026.09.29.01.59.50 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 29 Sep 2026 01:59:51 -0700 (PDT) Message-ID: <4f03112d-e5c5-486b-8317-1ecc1aeb6636@redhat.com> Date: Tue, 29 Sep 2026 10:59:50 +0200 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 0/4] net: qrtr: Add support for using identical MHI endpoint devices To: Manivannan Sadhasivam , Manivannan Sadhasivam , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Simon Horman , Jeff Johnson Cc: linux-arm-msm@vger.kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, ath12k@lists.infradead.org, Bjorn Andersson , Chris Lew , Deepak Kumar Singh , Raj Kumar Bhagat , Juha-Matti Tilli , Jeff Hugo , Vasanthakumar Thiagarajan References: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> Content-Language: en-US From: Paolo Abeni In-Reply-To: <20260922-qrtr-multi-ep-v3-0-c00831e88957@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 9/22/26 15:41, Manivannan Sadhasivam wrote: > This series reworks the QRTR driver to add support for using identical MHI > endpoint devices at the same time. Currently, QRTR driver has a limitation on > using more than one identical MHI endpoint devices like QCS6490 or any Qcom > Endpoint device making use of QRTR at the same time. Because of the fact that > these devices will have the identical QRTR node id, they cannot be used at the > same time, on the same host machine. > > This limitation is a blocker for running upstream kernel on devices like Qcom > based routers as they often have multiple identical WLAN Endpoint devices > connected to the Router SoC. > > This series supersedes the following 2 series from Juha: > https://lore.kernel.org/all/20260915054207.2513877-1-juha-matti.tilli@iki.fi > https://lore.kernel.org/all/20260915074135.2567411-1-juha-matti.tilli@iki.fi > > Compared to the series from Juha, this series simplifies the multi-endpoint > support by computing a unique node id for each MHI endpoint and uses it for the > internal QRTR book keeping. This ensures that even if the MHI endpoint devices > have same node ids, the host QRTR will always use a unique node id for each one > of them. > > More details can be found in the individual patches. > > Testing > ======= > > Juha tested this series on multi ath11k/12k setup by backporting this series to > 6.6 kernel. > > Merge Strategy > ============== > > Since both QRTR and ath drivers are falling under the networking tree, the whole > series can be merged through netdev tree. IMHO doable, with Johannes/Jeff ack. Anyhow the clashiko provided feedback looks relevant, please have a look. Also please note you are supposed to react to such feedback proactively. /P