From: Ferenc Fejes <fejes@inf.elte.hu>
To: Steve Williams <steve.williams@getcruise.com>
Cc: netdev@vger.kernel.org
Subject: Re: [EXT] Re: [PATCH net-next] sandlan: Add the sandlan virtual network interface
Date: Tue, 21 Feb 2023 11:19:07 +0100 [thread overview]
Message-ID: <4f07c0cb42ce191e8054fe816e7b8295425a16f2.camel@inf.elte.hu> (raw)
In-Reply-To: <CALHoRjcwnHGWKDLD_RO5W2yDSTBbmPUq+eEczk7v5FjuhKikLw@mail.gmail.com>
Hi Steve!
On Tue, 2022-11-29 at 09:54 -0800, Steve Williams wrote:
> On Tue, Nov 22, 2022 at 12:09 PM Andrew Lunn <andrew@lunn.ch> wrote:
> >
> > On Mon, Nov 21, 2022 at 06:59:11PM -0800, Steve Williams wrote:
> > > I have had trouble with the veth driver not transparently passing
> > > the
> > > full ethernet packets unaltered, and this is wreaking havoc with
> > > the
> > > hanic driver that I have (and that I'm submitting separately).
> > > That,
> > > and veth nodes only come in pairs, whereas with sandlan I can
> > > make
> > > more complex LANs and that allows me to emulate more complex
> > > situations. But fair point, and I am looking more closely at
> > > figuring
> > > out exactly what the veth driver is doing to my packets.
> >
> > If there is a real problem with veth, please describe it, so we can
> > fix the bugs. We don't add new emulators because of bugs in the
> > existing system.
>
> In light of the feedback I received here, I revisited the issue; and
> was able to get the veth driver to work after all, at least for
> regression tests of the hanic driver. I can't seem to reproduce the
> issue I thought I was having. So that kills one motivation for the
> sandlan driver, at least for me.
Good to know. I noticed your sandlan/hanic patches just now, and just
also wanted to tell that veth good enough for pretty much all 802.1CB
use-cases I'm aware of. In fact I use 2 veth paris in my .1CB testings
as well.
>
> --
>
> Stephen Williams
>
> Senior Software Engineer
>
> Cruise
>
Best,
Ferenc
next prev parent reply other threads:[~2023-02-21 10:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-16 22:24 [PATCH net-next] sandlan: Add the sandlan virtual network interface Steve Williams
2022-11-17 0:33 ` Andrew Lunn
2022-11-17 5:35 ` kernel test robot
2022-11-18 4:00 ` Jakub Kicinski
2022-11-22 2:59 ` [EXT] " Steve Williams
2022-11-22 4:02 ` Jakub Kicinski
2022-11-22 20:09 ` Andrew Lunn
2022-11-29 17:54 ` Steve Williams
2023-02-21 10:19 ` Ferenc Fejes [this message]
2022-11-21 14:04 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f07c0cb42ce191e8054fe816e7b8295425a16f2.camel@inf.elte.hu \
--to=fejes@inf.elte.hu \
--cc=netdev@vger.kernel.org \
--cc=steve.williams@getcruise.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).