From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-pg0-f42.google.com ([74.125.83.42]:46880 "EHLO mail-pg0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932419AbeCLCKD (ORCPT ); Sun, 11 Mar 2018 22:10:03 -0400 Received: by mail-pg0-f42.google.com with SMTP id r26so5890113pgv.13 for ; Sun, 11 Mar 2018 19:10:03 -0700 (PDT) Subject: Re: [PATCH net-next 2/4] selftests: forwarding: Exit with error when missing dependencies To: Ido Schimmel , netdev@vger.kernel.org Cc: davem@davemloft.net, jiri@mellanox.com, mlxsw@mellanox.com References: <20180311075725.15861-1-idosch@mellanox.com> <20180311075725.15861-3-idosch@mellanox.com> From: David Ahern Message-ID: <4f30bbbb-c7f2-4440-0632-036d2ac845eb@gmail.com> Date: Sun, 11 Mar 2018 20:10:01 -0600 MIME-Version: 1.0 In-Reply-To: <20180311075725.15861-3-idosch@mellanox.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 3/11/18 12:57 AM, Ido Schimmel wrote: > We already return an error when some dependencies (e.g., 'jq') are > missing so lets be consistent and do that for all. > > Signed-off-by: Ido Schimmel > Reviewed-by: Jiri Pirko > --- > tools/testing/selftests/net/forwarding/lib.sh | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > Reviewed-by: David Ahern