From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f194.google.com ([209.85.220.194]:46816 "EHLO mail-qk0-f194.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935331AbeCSSLh (ORCPT ); Mon, 19 Mar 2018 14:11:37 -0400 Received: by mail-qk0-f194.google.com with SMTP id o184so19283231qkd.13 for ; Mon, 19 Mar 2018 11:11:37 -0700 (PDT) Subject: Re: [PATCH net-next 3/4] net: dsa: Plug in PHYLINK support To: Russell King - ARM Linux Cc: Andrew Lunn , netdev@vger.kernel.org, privat@egil-hjelmeland.no, vivien.didelot@savoirfairelinux.com, davem@davemloft.net, sean.wang@mediatek.com, Woojung.Huh@microchip.com, john@phrozen.org, cphealy@gmail.com References: <20180318185246.19311-1-f.fainelli@gmail.com> <20180318185246.19311-4-f.fainelli@gmail.com> <20180318191923.GN1188@lunn.ch> <639992a2-d651-8030-1a54-919e8e5827cf@gmail.com> <20180319180929.GF2743@n2100.armlinux.org.uk> From: Florian Fainelli Message-ID: <4f331a7a-49bd-3f84-1437-ac42141abf18@gmail.com> Date: Mon, 19 Mar 2018 11:11:27 -0700 MIME-Version: 1.0 In-Reply-To: <20180319180929.GF2743@n2100.armlinux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org List-ID: On 03/19/2018 11:09 AM, Russell King - ARM Linux wrote: > On Mon, Mar 19, 2018 at 10:59:55AM -0700, Florian Fainelli wrote: >> Hi Andrew, >> >> On 03/18/2018 12:19 PM, Andrew Lunn wrote: >>>> +static int dsa_slave_nway_reset(struct net_device *dev) >>>> +{ >>>> + struct dsa_port *dp = dsa_slave_to_port(dev); >>>> + >>>> + return phylink_ethtool_nway_reset(dp->pl); >>>> +} >>> >>> Hi Florian >>> >>> I've seen in one of Russells trees a patch to put a phylink into >>> net_device. That would make a generic slave_nway_reset() possible, and >>> a few others as well. Maybe it makes sense to pull in that patch? >> >> To make this generic, we would have to have net_device carry a reference >> to a phylink instance, which I would rather not do. Were you possibly >> referring to this patch set: >> >> http://git.armlinux.org.uk/cgit/linux-arm.git/commit/?h=phy&id=4eda3b76573473d811bc80a6f0e5a2e06dd76bf6 >> >> in which case I think it was discussed and rejected (that was my >> recollection). > > Unfortunately, that rejection kind'a prevents SFP support on a PHY, > which is why I'm not pushing the 3310 patches (I don't have any other > solution to this problem at the moment as PHYLIB gets in the way of > knowing what state the network interface is in.) I don't remember the basis on which this was rejected, and since then, I had many sleepless nights which don't help with long term memory :) Can you refresh the context? -- Florian