From: Tariq Toukan <ttoukan.linux@gmail.com>
To: Sagi Grimberg <sagi@grimberg.me>, Christoph Hellwig <hch@lst.de>,
Anna Schumaker <Anna.Schumaker@Netapp.com>,
Trond Myklebust <trondmy@kernel.org>,
linux-nfs@vger.kernel.org, Boris Pismenny <borisp@nvidia.com>,
John Fastabend <john.fastabend@gmail.com>,
Jakub Kicinski <kuba@kernel.org>
Cc: Saeed Mahameed <saeedm@nvidia.com>, Gal Pressman <gal@nvidia.com>,
Networking <netdev@vger.kernel.org>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
"David S. Miller" <davem@davemloft.net>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Leon Romanovsky <leon@kernel.org>,
Tariq Toukan <tariqt@nvidia.com>
Subject: Re: [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy
Date: Tue, 6 Aug 2024 07:43:48 +0300 [thread overview]
Message-ID: <4f42fac4-2a4e-426a-be86-1f4bb79987b4@gmail.com> (raw)
In-Reply-To: <77fb3db5-7a59-4879-b9c2-d3408fcf67e8@grimberg.me>
On 05/08/2024 14:43, Sagi Grimberg wrote:
>
>
>
> On 05/08/2024 13:40, Tariq Toukan wrote:
>> Hi,
>>
>> A recent patch [1] to 'fs' broke the TX TLS device-offloaded flow
>> starting from v6.11-rc1.
>>
>> The kernel crashes. Different runs result in different kernel traces.
>> See below [2].
>> All of them disappear once patch [1] is reverted.
>>
>> The issues appears only with "sendfile on and zerocopy on".
>> We couldn't repro with "sendfile off", or with "sendfile on and
>> zerocopy off".
>>
>> The repro test is as simple as a repeated client/server communication
>> (wrk/nginx), with sendfile on and zc on, and with "tls-hw-tx-offload:
>> on".
>>
>> $ for i in `seq 10`; do wrk -b::2:2:2:3 -t10 -c100 -d15 --timeout 5s
>> https://[::2:2:2:2]:20448/16000b.img; done
>>
>> We can provide more details if needed, to help with the analysis and
>> debug.
>
> Does tls sw (i.e. no offload) also break?
>
No it doesn't.
Only the "sendfile with ZC" flow of the TX device-offloaded TLS.
next prev parent reply other threads:[~2024-08-06 4:43 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-05 10:40 [Bug report] NFS patch breaks TLS device-offloaded TX zerocopy Tariq Toukan
2024-08-05 11:43 ` Sagi Grimberg
2024-08-06 4:43 ` Tariq Toukan [this message]
2024-08-06 8:09 ` Sagi Grimberg
2024-08-06 10:07 ` Tariq Toukan
2024-08-11 11:21 ` Tariq Toukan
2024-08-11 18:33 ` Sagi Grimberg
2024-08-12 13:15 ` Tariq Toukan
2024-08-12 13:23 ` Christoph Hellwig
2024-08-12 9:02 ` Christoph Hellwig
2024-08-12 9:13 ` Sagi Grimberg
2024-08-12 11:06 ` Christoph Hellwig
2024-08-12 23:23 ` Jakub Kicinski
2024-11-14 19:05 ` Tariq Toukan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f42fac4-2a4e-426a-be86-1f4bb79987b4@gmail.com \
--to=ttoukan.linux@gmail.com \
--cc=Anna.Schumaker@Netapp.com \
--cc=borisp@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=hch@lst.de \
--cc=john.fastabend@gmail.com \
--cc=kuba@kernel.org \
--cc=leon@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nfs@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=sagi@grimberg.me \
--cc=tariqt@nvidia.com \
--cc=trondmy@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).