From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5901AC43381 for ; Thu, 14 Feb 2019 19:04:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1778121B24 for ; Thu, 14 Feb 2019 19:04:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ex7wsleQ" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2405153AbfBNTEv (ORCPT ); Thu, 14 Feb 2019 14:04:51 -0500 Received: from mail-pl1-f193.google.com ([209.85.214.193]:45577 "EHLO mail-pl1-f193.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726129AbfBNTEv (ORCPT ); Thu, 14 Feb 2019 14:04:51 -0500 Received: by mail-pl1-f193.google.com with SMTP id r14so3611490pls.12 for ; Thu, 14 Feb 2019 11:04:51 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=Nc3hR6eoa4CcyGWt5izKfVElUPAB+bBM9EqqjdtbsrM=; b=ex7wsleQ+w/tngj94FNNkJs3C29Jbgy+pMG41bzj4pAA9ipDoMPZuBKSBL3QAmN1IW UlWdHWuSgXmVoyhxmEcS41uolUBCNrDr8k42DrymPZxOLpA6tlnRiFqHmLJ8UScnxbYT MolsAVmM9F/f9qwUttaXcVr7HRXLMRvDXFbhKQ0Zy7DyCtruGNpJECyY5zG9gyeUUrg8 5GfdZUSVbyHhMGdst9DzxbnYTPGUGEP6DZJ1CzK24TGcd9UMM/OqTzHfB+UQoPVDiz/p +dF+CA6PhDNKBPYyFFxhEegB76S+EtNrz3t26huQqw9vHtRK5KOUyrZZynAABFbuvttA qPgg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=Nc3hR6eoa4CcyGWt5izKfVElUPAB+bBM9EqqjdtbsrM=; b=KWxolNCZ1cuoKwtZYJA0PjYM2SWEhhNp5WmaHE0zHNQIwMFaX0pIdCF4irsTfYz0Pc GSlzh4APYPPMVto8LAwElh+XmJ/DaWqnP9E9idEXxckuTTzAD0SzCBf9x0ahMsKflM36 HTHX1aU3QPg2/pxxezvRtvGDJI83ZI0dtshD9oATJ0Ev+CjMpztzuh0bZZWddbJHutOR iW1ERtK9/aSROgjj+6o7kUj7meDEx8fS2btoRItG1n1nWcr3W7TKK0BIrXtdpCthSCUW sYtQLy3RLuPqTGa+Ppej7/Fo0QXmppuqqwEQ2NDEcn4A3Ex35UN0Bymk6qPfqvO8mVne uVMQ== X-Gm-Message-State: AHQUAuavx6L/a69YmCFLKm5qAmwi0ifaLa7TAaPDhRZ1dKLfx7GkYlHY n9Lnn3MOlSq0zpEAFoSs/BA= X-Google-Smtp-Source: AHgI3Ibc6on1TZbqGg0btheOtnKTzm5fbzE9IjME+abikPAcYwhUoAVXhksT0OKn/jsXokmlz7/8DA== X-Received: by 2002:a17:902:7293:: with SMTP id d19mr5542012pll.29.1550171090911; Thu, 14 Feb 2019 11:04:50 -0800 (PST) Received: from ?IPv6:2601:282:800:fd80:fcca:3d2d:5c58:2370? ([2601:282:800:fd80:fcca:3d2d:5c58:2370]) by smtp.googlemail.com with ESMTPSA id t86sm5300266pfi.158.2019.02.14.11.04.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 14 Feb 2019 11:04:50 -0800 (PST) Subject: Re: [PATCH bpf-next v2] bpf: fix memory leak in bpf_lwt_xmit_reroute To: Peter Oskolkov , Alexei Starovoitov , Daniel Borkmann , netdev@vger.kernel.org Cc: Peter Oskolkov , Willem de Bruijn References: <20190214183931.20293-1-posk@google.com> From: David Ahern Message-ID: <4f4ce7f6-a9df-b898-8de5-05dcbf15b095@gmail.com> Date: Thu, 14 Feb 2019 12:04:47 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190214183931.20293-1-posk@google.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On 2/14/19 11:39 AM, Peter Oskolkov wrote: > On error the skb should be freed. Tested with diff/steps > provided by David Ahern. > > v2: surface routing errors to the user instead of a generic EINVAL, > as suggested by David Ahern. > > Reported-by: David Ahern > Fixes: 3bd0b15281af ("bpf: add handling of BPF_LWT_REROUTE to lwt_bpf.c") > Signed-off-by: Peter Oskolkov > --- > net/core/lwt_bpf.c | 29 ++++++++++++++++++++--------- > 1 file changed, 20 insertions(+), 9 deletions(-) > Reviewed-by: David Ahern