From: Harsh Jain <harsh@chelsio.com>
To: Lino Sanfilippo <LinoSanfilippo@gmx.de>,
herbert@gondor.apana.org.au, atul.gupta@chelsio.com,
indranil@chelsio.com, swise@opengridcomputing.com,
varun@chelsio.com, ganeshgr@chelsio.com, netdev@vger.kernel.org,
linux-crypto@vger.kernel.org
Subject: Re: [PATCH 1/1] crypto:chelsio: Update ntx queue received from cxgb4
Date: Sat, 13 Oct 2018 12:53:36 +0530 [thread overview]
Message-ID: <4f628759-bd3a-d7d3-6be2-e3dba759fdf3@chelsio.com> (raw)
In-Reply-To: <7e220dd5-fb54-84b4-20c9-a318d18d747b@gmx.de>
On 13-10-2018 05:46, Lino Sanfilippo wrote:
> Hi,
>
>> + if (uld_type == CXGB4_ULD_CRYPTO) {
>> + i = min_t(int, adap->vres.ncrypto_fc,
>> + num_online_cpus());
>> + txq_info->ntxq = rounddown(i, adap->params.nports);
>> + if (txq_info->ntxq <= 0) {
>> + dev_warn(adap->pdev_dev, "Crypto Tx Queues can't be zero\n");
>> + return -EINVAL;
>> + }
> Shouldn't we free txq_info in the error case?
Yes, Will fix this in V2. Thanks.
>
> Regards,
> Lino
prev parent reply other threads:[~2018-10-13 14:59 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1539343454.git.harsh@chelsio.com>
2018-10-12 11:46 ` [PATCH 1/1] crypto:chelsio: Update ntx queue received from cxgb4 Harsh Jain
2018-10-13 0:16 ` Lino Sanfilippo
2018-10-13 7:23 ` Harsh Jain [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f628759-bd3a-d7d3-6be2-e3dba759fdf3@chelsio.com \
--to=harsh@chelsio.com \
--cc=LinoSanfilippo@gmx.de \
--cc=atul.gupta@chelsio.com \
--cc=ganeshgr@chelsio.com \
--cc=herbert@gondor.apana.org.au \
--cc=indranil@chelsio.com \
--cc=linux-crypto@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=swise@opengridcomputing.com \
--cc=varun@chelsio.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox