From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EE99E23CC for ; Tue, 15 Aug 2023 09:15:05 +0000 (UTC) Received: from mail-pl1-x62b.google.com (mail-pl1-x62b.google.com [IPv6:2607:f8b0:4864:20::62b]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 28DC610D8 for ; Tue, 15 Aug 2023 02:15:02 -0700 (PDT) Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1bba9539a23so9041475ad.1 for ; Tue, 15 Aug 2023 02:15:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance.com; s=google; t=1692090901; x=1692695701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=N6UPah3rxy6GE+IW6hhaEXFukV19/RQgo9PDGSDaxjc=; b=B4NWnukFtWBpBFBooLjjX+4xRi6cYrfaI8iegReeVzLQWKPXXt1CxHdKL4/tZ0fNPM 0UExtQR6YZe58qkKHpbXtHQV0uPapic2RYOUTB+6Pi7LdOE1C7GEcaF7+zgpTtYtD/de UlP+/TDXrfMVghqI9OT3wDmB4f+60Ecld4ptmi3g4OGE44+/xTS+dFaCetp2KrysicqF +aYy3xTBT6yAIsFwZB/EdPqMFUGo82MatiM8ko8K8L/pW/bDYDRzwOeVlfM6AvdWPq+b HcGAAnq5GXzxPWbDmjMNdTVLUEtTfSjxZmvfFI4JrMMNezs7y6COdvHcs3klmaxHW6vC FHlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1692090901; x=1692695701; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=N6UPah3rxy6GE+IW6hhaEXFukV19/RQgo9PDGSDaxjc=; b=JuYZywOM9b7DdHsqqj9H6uVCrOLeYIpgFgbNkYsvj7VlPjB/jWaxQ3FH1NEouIv4VA 52/hKcaz9rAsbyxQLAxzEjpDTWtiGKG8q46VZktIceBd5gT/qgz+xp+AMPml47hd1JQG WIgYypf30BTpIb4hQj9eix+LFW/aF8EY8rStsc9I/k38LCcz5StnITJ5Aa9APFPLe/UR uwdBgo1UA8F7nFobfuhhvYox0nqn8Nc1/9pO/neBf/yvcQ/kFMYIf5wm9JwcRo1aWR+Z /Ui5Q4CtB9v4IbdmdNGHs2ogTb4UNLgCdxX24SMAtGCKoyCiWzN5xI5bsZbMrcC5gyen /LpA== X-Gm-Message-State: AOJu0YwjVi9BgdUgbRx/sfep7qnAmsh9Mt3V0ZCSD2qboHraDOqmF6PW 8sYCPLpWfKWVQhRC2lzWzyKLrw== X-Google-Smtp-Source: AGHT+IGKaQyK0d17VyjHV7p/Fr8yAF+2JMAJsl65uoihXD9UcmAUSi1eF134pFnOBdZUKl9ThFMr5Q== X-Received: by 2002:a17:902:e5c8:b0:1bb:83ec:832 with SMTP id u8-20020a170902e5c800b001bb83ec0832mr13866844plf.2.1692090901535; Tue, 15 Aug 2023 02:15:01 -0700 (PDT) Received: from ?IPV6:fdbd:ff1:ce00:1c25:884:3ed:e1db:b610? ([240e:694:e21:b::2]) by smtp.gmail.com with ESMTPSA id io13-20020a17090312cd00b001b39ffff838sm10630843plb.25.2023.08.15.02.14.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 15 Aug 2023 02:15:01 -0700 (PDT) Message-ID: <4f64cd2d-90e8-7902-7ef7-1ac58d51b2a8@bytedance.com> Date: Tue, 15 Aug 2023 17:14:40 +0800 Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.14.0 Subject: Re: [PATCH v4 01/48] mm: move some shrinker-related function declarations to mm/internal.h Content-Language: en-US To: Muchun Song Cc: Andrew Morton , david@fromorbit.com, tkhai@ya.ru, Vlastimil Babka , Roman Gushchin , djwong@kernel.org, Christian Brauner , "Paul E. McKenney" , tytso@mit.edu, steven.price@arm.com, cel@kernel.org, Sergey Senozhatsky , yujie.liu@intel.com, Greg KH , simon.horman@corigine.com, dlemoal@kernel.org, LKML , Linux-MM , x86@kernel.org, kvm@vger.kernel.org, xen-devel@lists.xenproject.org, linux-erofs@lists.ozlabs.org, linux-f2fs-devel@lists.sourceforge.net, cluster-devel@redhat.com, linux-nfs@vger.kernel.org, linux-mtd@lists.infradead.org, rcu@vger.kernel.org, netdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-arm-msm@vger.kernel.org, dm-devel@redhat.com, linux-raid@vger.kernel.org, linux-bcache@vger.kernel.org, virtualization@lists.linux-foundation.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org References: <20230807110936.21819-1-zhengqi.arch@bytedance.com> <20230807110936.21819-2-zhengqi.arch@bytedance.com> From: Qi Zheng In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Status: No, score=-3.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,NICE_REPLY_A, RCVD_IN_DNSWL_BLOCKED,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net On 2023/8/15 16:36, Muchun Song wrote: > > >> On Aug 7, 2023, at 19:08, Qi Zheng wrote: >> >> The following functions are only used inside the mm subsystem, so it's >> better to move their declarations to the mm/internal.h file. >> >> 1. shrinker_debugfs_add() >> 2. shrinker_debugfs_detach() >> 3. shrinker_debugfs_remove() >> >> Signed-off-by: Qi Zheng > > Reviewed-by: Muchun Song > > One nit bellow. > > [...] > >> + >> +/* >> + * shrinker related functions >> + */ > > This is a multi-comment format. "/* shrinker related functions. */" is > the right one-line format of comment. Will do. Thanks, Qi > >> + >> +#ifdef CONFIG_SHRINKER_DEBUG >> +extern int shrinker_debugfs_add(struct shrinker *shrinker); >> +extern struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, >> + int *debugfs_id); >> +extern void shrinker_debugfs_remove(struct dentry *debugfs_entry, >> + int debugfs_id); >> +#else /* CONFIG_SHRINKER_DEBUG */ >> +static inline int shrinker_debugfs_add(struct shrinker *shrinker) >> +{ >> + return 0; >> +} >> +static inline struct dentry *shrinker_debugfs_detach(struct shrinker *shrinker, >> + int *debugfs_id) >> +{ >> + *debugfs_id = -1; >> + return NULL; >> +} >> +static inline void shrinker_debugfs_remove(struct dentry *debugfs_entry, >> + int debugfs_id) >> +{ >> +} >> +#endif /* CONFIG_SHRINKER_DEBUG */ >> + >> #endif /* __MM_INTERNAL_H */ >> -- >> 2.30.2 >> >