From: Venkat Venkatsubra <venkat.x.venkatsubra@oracle.com>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: netdev@vger.kernel.org, xen-devel@lists.xenproject.org,
davem@davemloft.net, david.vrabel@citrix.com,
Konrad Wilk <konrad.wilk@oracle.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
wei.liu2@citrix.com, paul.durrant@citrix.com
Subject: RE: [PATCH] xen-netfront: reset skb transport header before checksum
Date: Tue, 12 May 2015 07:00:16 -0700 (PDT) [thread overview]
Message-ID: <4f89e3e5-3fa8-4313-b6fb-c68a149508f3@default> (raw)
In-Reply-To: <1431395493.566.54.camel@edumazet-glaptop2.roam.corp.google.com>
>
> This looks bogus for IPv6.
>
> I would rather fix skb_checksum_setup_ip() and
> skb_checksum_setup_ipv6(), since you already use correctly
> skb_maybe_pull_tail() there.
>
> In general, setting network and transport header at this point seems
> extra work.
>
Yes, I missed the IPv6 case. ;-) Thanks Eric for pointing that out.
Looking further the below commit might have already resolved the issue.
commit e5d5decaedf41f5b03e6819789cc3ba8744d9f54
Author: Jason Wang <jasowang@redhat.com>
Date: Tue Mar 26 23:11:20 2013 +0000
net: core: let skb_partial_csum_set() set transport header
For untrusted packets with partial checksum, we need to set the transport he
for precise packet length estimation. We can just let skb_pratial_csum_set()
do this to avoid extra call to skb_flow_dissect() and simplify the caller.
Cc: Eric Dumazet <edumazet@google.com>
Signed-off-by: Jason Wang <jasowang@redhat.com>
Acked-by: Eric Dumazet <edumazet@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
The guest we were running was older to this and didn't have the above commit.
Thanks.
Venkat
prev parent reply other threads:[~2015-05-12 14:00 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-12 1:34 [PATCH] xen-netfront: reset skb transport header before checksum Venkat Venkatsubra
2015-05-12 1:51 ` Eric Dumazet
2015-05-12 14:00 ` Venkat Venkatsubra [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4f89e3e5-3fa8-4313-b6fb-c68a149508f3@default \
--to=venkat.x.venkatsubra@oracle.com \
--cc=boris.ostrovsky@oracle.com \
--cc=davem@davemloft.net \
--cc=david.vrabel@citrix.com \
--cc=eric.dumazet@gmail.com \
--cc=konrad.wilk@oracle.com \
--cc=netdev@vger.kernel.org \
--cc=paul.durrant@citrix.com \
--cc=wei.liu2@citrix.com \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox