netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Philipp Zabel <p.zabel@pengutronix.de>,
	Johannes Berg <johannes@sipsolutions.net>
Cc: netdev@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-wireless@vger.kernel.org,
	kernel@pengutronix.de
Subject: Re: [PATCH 2/2] net: rfkill: gpio: add DT support
Date: Thu, 22 Dec 2022 11:32:51 +0100	[thread overview]
Message-ID: <4fa68299-cc69-3856-dc3d-75f7db3dbd7a@kernel.org> (raw)
In-Reply-To: <20221221104803.1693874-2-p.zabel@pengutronix.de>

On 21/12/2022 11:48, Philipp Zabel wrote:
> Allow probing rfkill-gpio via device tree. This just hooks up the
> already existing support that was started in commit 262c91ee5e52 ("net:
> rfkill: gpio: prepare for DT and ACPI support") via the "rfkill-gpio"
> compatible.
> 
> Signed-off-by: Philipp Zabel <p.zabel@pengutronix.de>
> ---
>  net/rfkill/rfkill-gpio.c | 9 +++++++++
>  1 file changed, 9 insertions(+)
> 
> diff --git a/net/rfkill/rfkill-gpio.c b/net/rfkill/rfkill-gpio.c
> index f5afc9bcdee6..9f763654cd27 100644
> --- a/net/rfkill/rfkill-gpio.c
> +++ b/net/rfkill/rfkill-gpio.c
> @@ -157,12 +157,21 @@ static const struct acpi_device_id rfkill_acpi_match[] = {
>  MODULE_DEVICE_TABLE(acpi, rfkill_acpi_match);
>  #endif
>  
> +#ifdef CONFIG_OF

__maybe_unused instead

> +static const struct of_device_id rfkill_of_match[] = {
> +	{ .compatible = "rfkill-gpio", },
> +	{ },
> +};
> +MODULE_DEVICE_TABLE(of, rfkill_of_match);


Best regards,
Krzysztof


  reply	other threads:[~2022-12-22 10:33 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-21 10:48 [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding Philipp Zabel
2022-12-21 10:48 ` [PATCH 2/2] net: rfkill: gpio: add DT support Philipp Zabel
2022-12-22 10:32   ` Krzysztof Kozlowski [this message]
2022-12-21 14:45 ` [PATCH 1/2] dt-bindings: net: Add rfkill-gpio binding Rob Herring
2022-12-21 15:36   ` Philipp Zabel
2022-12-22 10:32     ` Krzysztof Kozlowski
2022-12-22 10:20 ` Krzysztof Kozlowski
2023-01-02 17:40   ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4fa68299-cc69-3856-dc3d-75f7db3dbd7a@kernel.org \
    --to=krzk@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=johannes@sipsolutions.net \
    --cc=kernel@pengutronix.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).