From: Gerhard Engleder <gerhard@engleder-embedded.com>
To: Paolo Abeni <pabeni@redhat.com>,
netdev@vger.kernel.org, bpf@vger.kernel.org
Cc: davem@davemloft.net, kuba@kernel.org, edumazet@google.com,
bjorn@kernel.org, magnus.karlsson@intel.com,
maciej.fijalkowski@intel.com, jonathan.lemon@gmail.com
Subject: Re: [PATCH net 2/2] tsnep: Fix XDP_RING_NEED_WAKEUP for empty fill ring
Date: Thu, 25 Jan 2024 22:50:00 +0100 [thread overview]
Message-ID: <4fe10d68-e48c-446f-96f7-157b85b1a6fb@engleder-embedded.com> (raw)
In-Reply-To: <41a9cd95c940aeb418f45a1d4e3ff4b0e8f62d5a.camel@redhat.com>
On 25.01.24 12:06, Paolo Abeni wrote:
> On Tue, 2024-01-23 at 21:09 +0100, Gerhard Engleder wrote:
>> + if (xsk_uses_need_wakeup(rx->xsk_pool)) {
>> + int desc_available = tsnep_rx_desc_available(rx);
>> +
>> + if (desc_available)
>> + xsk_set_rx_need_wakeup(rx->xsk_pool);
>> + else
>> + xsk_clear_rx_need_wakeup(rx->xsk_pool);
>> + }
>> }
>>
>> static bool tsnep_pending(struct tsnep_queue *queue)
>
> The patch LGTM, but there is a very similar chunk of code in
> tsnep_rx_poll_zc(). You should consider a net-next follow-up
> consolidating the code in a common helper.
I will do. Thanks!
next prev parent reply other threads:[~2024-01-25 22:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-23 20:09 [PATCH net 0/2] tsnep: XDP fixes Gerhard Engleder
2024-01-23 20:09 ` [PATCH net 1/2] tsnep: Remove FCS for XDP data path Gerhard Engleder
2024-01-23 20:09 ` [PATCH net 2/2] tsnep: Fix XDP_RING_NEED_WAKEUP for empty fill ring Gerhard Engleder
2024-01-25 11:06 ` Paolo Abeni
2024-01-25 21:50 ` Gerhard Engleder [this message]
2024-01-25 11:10 ` [PATCH net 0/2] tsnep: XDP fixes patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe10d68-e48c-446f-96f7-157b85b1a6fb@engleder-embedded.com \
--to=gerhard@engleder-embedded.com \
--cc=bjorn@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jonathan.lemon@gmail.com \
--cc=kuba@kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).