From: Andrew Lunn <andrew@lunn.ch>
To: Caleb James DeLisle <cjd@cjdns.fr>
Cc: netdev@vger.kernel.org, daniel@makrotopia.org, dqfext@gmail.com,
SkyLake.Huang@mediatek.com, hkallweit1@gmail.com,
linux@armlinux.org.uk, davem@davemloft.net, edumazet@google.com,
kuba@kernel.org, pabeni@redhat.com, matthias.bgg@gmail.com,
angelogioacchino.delregno@collabora.com,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-mediatek@lists.infradead.org
Subject: Re: [PATCH net-next] net: phy: mediatek: do not match MT7530 PHY if 10/100 only
Date: Fri, 18 Sep 2026 18:29:58 +0200 [thread overview]
Message-ID: <4fe68c4b-b72e-4cbb-9a0e-2731ec68888c@lunn.ch> (raw)
In-Reply-To: <20260918161156.377822-1-cjd@cjdns.fr>
On Fri, Sep 18, 2026 at 04:11:56PM +0000, Caleb James DeLisle wrote:
> An EcoNet SoC 10/100 PHY uses the same ID as the MT7530 PHY, but a true
> MT7530 PHY always has gigabit support so they can be distinguished by
> the presence of the ESTATUS_1000_TFULL flag. Add a match_phy_device
> which refuses to match if the PHY is not gigabit.
Don't you also need the opposite in mtk-fe-soc.c? Otherwise don't you
rely on the load order of the PHY drivers?
Andrew
---
pw-bot: cr
next prev parent reply other threads:[~2026-09-18 16:30 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-18 16:11 [PATCH net-next] net: phy: mediatek: do not match MT7530 PHY if 10/100 only Caleb James DeLisle
2026-09-18 16:29 ` Andrew Lunn [this message]
2026-09-18 16:47 ` Caleb James DeLisle
2026-09-18 16:58 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fe68c4b-b72e-4cbb-9a0e-2731ec68888c@lunn.ch \
--to=andrew@lunn.ch \
--cc=SkyLake.Huang@mediatek.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=cjd@cjdns.fr \
--cc=daniel@makrotopia.org \
--cc=davem@davemloft.net \
--cc=dqfext@gmail.com \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux@armlinux.org.uk \
--cc=matthias.bgg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox