From: "Govindarajulu Varadarajan (gvaradar)" <gvaradar@cisco.com>
To: "baijiaju1990@gmail.com" <baijiaju1990@gmail.com>,
"_govind@gmx.com" <_govind@gmx.com>,
"Christian Benvenuti (benve)" <benve@cisco.com>,
"Parvi Kaustubhi (pkaustub)" <pkaustub@cisco.com>
Cc: "netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL
Date: Sat, 4 Aug 2018 00:54:15 +0000 [thread overview]
Message-ID: <4fefa848e281ffa5380eddee1b77553b48b0da09.camel@cisco.com> (raw)
In-Reply-To: <20180804004009.18928-1-baijiaju1990@gmail.com>
On Sat, 2018-08-04 at 08:40 +0800, Jia-Ju Bai wrote:
> vnic_dev_register(), vnic_rq_alloc_bufs() and vnic_wq_alloc_bufs()
> are never called in atomic context.
> They call kzalloc() with GFP_ATOMIC, which is not necessary.
> GFP_ATOMIC can be replaced with GFP_KERNEL.
>
> This is found by a static analysis tool named DCNS written by myself.
Looks good to me. Thanks you.
Acked-by: Govindarajulu Varadarajan <gvaradar@cisco.com>
next prev parent reply other threads:[~2018-08-04 2:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-04 0:40 [PATCH] net: cisco: enic: Replace GFP_ATOMIC with GFP_KERNEL Jia-Ju Bai
2018-08-04 0:54 ` Govindarajulu Varadarajan (gvaradar) [this message]
2018-08-04 20:08 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4fefa848e281ffa5380eddee1b77553b48b0da09.camel@cisco.com \
--to=gvaradar@cisco.com \
--cc=_govind@gmx.com \
--cc=baijiaju1990@gmail.com \
--cc=benve@cisco.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pkaustub@cisco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox