From: Martin KaFai Lau <martin.lau@linux.dev>
To: Jason Xing <kerneljasonxing@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com, dsahern@kernel.org,
willemdebruijn.kernel@gmail.com, willemb@google.com,
ast@kernel.org, daniel@iogearbox.net, andrii@kernel.org,
eddyz87@gmail.com, song@kernel.org, yonghong.song@linux.dev,
john.fastabend@gmail.com, kpsingh@kernel.org, sdf@fomichev.me,
haoluo@google.com, jolsa@kernel.org, horms@kernel.org,
bpf@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH bpf-next v11 09/12] bpf: add BPF_SOCK_OPS_TS_ACK_OPT_CB callback
Date: Fri, 14 Feb 2025 15:41:06 -0800 [thread overview]
Message-ID: <4ff9b840-9ba1-4217-a332-d5fcd1cf983a@linux.dev> (raw)
In-Reply-To: <CAL+tcoCYcpaBDG8GRyP1Fk8WYHAo4ic1YNhmazXEysYUWSTqxg@mail.gmail.com>
On 2/14/25 3:16 PM, Jason Xing wrote:
> On Sat, Feb 15, 2025 at 4:34 AM Martin KaFai Lau <martin.lau@linux.dev> wrote:
>>
>> On 2/13/25 5:00 PM, Jason Xing wrote:
>>> diff --git a/net/dsa/user.c b/net/dsa/user.c
>>> index 291ab1b4acc4..794fe553dd77 100644
>>> --- a/net/dsa/user.c
>>> +++ b/net/dsa/user.c
>>> @@ -897,7 +897,7 @@ static void dsa_skb_tx_timestamp(struct dsa_user_priv *p,
>>> {
>>> struct dsa_switch *ds = p->dp->ds;
>>>
>>> - if (!(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP))
>>> + if (!(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP_NOBPF))
>>
>> This change should be in patch 8.
>>
>> [ ... ]
>>
>>> diff --git a/net/socket.c b/net/socket.c
>>> index 262a28b59c7f..517de433d4bb 100644
>>> --- a/net/socket.c
>>> +++ b/net/socket.c
>>> @@ -676,7 +676,7 @@ void __sock_tx_timestamp(__u32 tsflags, __u8 *tx_flags)
>>> u8 flags = *tx_flags;
>>>
>>> if (tsflags & SOF_TIMESTAMPING_TX_HARDWARE) {
>>> - flags |= SKBTX_HW_TSTAMP;
>>> + flags |= SKBTX_HW_TSTAMP_NOBPF;
>>
>> Same here.
>
> Sure, you're right. If you feel it's necessary to re-spin, I will
> adjust these two points :)
That will be good. I would wait a bit to collect Willem's comment first.
next prev parent reply other threads:[~2025-02-14 23:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-14 1:00 [PATCH bpf-next v11 00/12] net-timestamp: bpf extension to equip applications transparently Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 01/12] bpf: add networking timestamping support to bpf_get/setsockopt() Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 02/12] bpf: prepare the sock_ops ctx and call bpf prog for TX timestamping Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 03/12] bpf: prevent unsafe access to the sock fields in the BPF timestamping callback Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 04/12] bpf: disable unsafe helpers in TX timestamping callbacks Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 05/12] net-timestamp: prepare for isolating two modes of SO_TIMESTAMPING Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 06/12] bpf: add BPF_SOCK_OPS_TS_SCHED_OPT_CB callback Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 07/12] bpf: add BPF_SOCK_OPS_TS_SW_OPT_CB callback Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 08/12] bpf: add BPF_SOCK_OPS_TS_HW_OPT_CB callback Jason Xing
2025-02-15 15:06 ` Willem de Bruijn
2025-02-15 16:20 ` Jason Xing
2025-02-15 18:08 ` Willem de Bruijn
2025-02-15 22:23 ` Jason Xing
2025-02-15 22:58 ` Martin KaFai Lau
2025-02-15 23:10 ` Jason Xing
2025-02-16 14:36 ` Willem de Bruijn
2025-02-16 14:45 ` Jason Xing
2025-02-16 14:48 ` Jason Xing
2025-02-16 16:17 ` Jason Xing
2025-02-18 0:56 ` Willem de Bruijn
2025-02-18 4:51 ` Jason Xing
2025-02-18 0:55 ` Willem de Bruijn
2025-02-14 1:00 ` [PATCH bpf-next v11 09/12] bpf: add BPF_SOCK_OPS_TS_ACK_OPT_CB callback Jason Xing
2025-02-14 20:33 ` Martin KaFai Lau
2025-02-14 23:16 ` Jason Xing
2025-02-14 23:41 ` Martin KaFai Lau [this message]
2025-02-15 15:16 ` Willem de Bruijn
2025-02-14 1:00 ` [PATCH bpf-next v11 10/12] bpf: add BPF_SOCK_OPS_TS_SND_CB callback Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 11/12] bpf: support selective sampling for bpf timestamping Jason Xing
2025-02-15 15:10 ` Willem de Bruijn
2025-02-15 16:17 ` Jason Xing
2025-02-15 18:01 ` Willem de Bruijn
2025-02-15 21:11 ` Jason Xing
2025-02-14 1:00 ` [PATCH bpf-next v11 12/12] selftests/bpf: add simple bpf tests in the tx path for timestamping feature Jason Xing
2025-02-14 20:40 ` Martin KaFai Lau
2025-02-14 23:18 ` Jason Xing
2025-02-15 15:15 ` Willem de Bruijn
2025-02-15 16:17 ` Jason Xing
2025-02-15 18:01 ` Willem de Bruijn
2025-02-14 20:42 ` [PATCH bpf-next v11 00/12] net-timestamp: bpf extension to equip applications transparently Martin KaFai Lau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ff9b840-9ba1-4217-a332-d5fcd1cf983a@linux.dev \
--to=martin.lau@linux.dev \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=eddyz87@gmail.com \
--cc=edumazet@google.com \
--cc=haoluo@google.com \
--cc=horms@kernel.org \
--cc=john.fastabend@gmail.com \
--cc=jolsa@kernel.org \
--cc=kerneljasonxing@gmail.com \
--cc=kpsingh@kernel.org \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=song@kernel.org \
--cc=willemb@google.com \
--cc=willemdebruijn.kernel@gmail.com \
--cc=yonghong.song@linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).