netdev.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH net-next] r8152: Advertise software timestamp information.
@ 2025-10-14  5:52 rawal.abhishek92
  2025-10-14 11:05 ` Vadim Fedorenko
  2025-10-15 20:40 ` patchwork-bot+netdevbpf
  0 siblings, 2 replies; 3+ messages in thread
From: rawal.abhishek92 @ 2025-10-14  5:52 UTC (permalink / raw)
  To: Andrew Lunn, David S. Miller, Eric Dumazet, Jakub Kicinski,
	Paolo Abeni
  Cc: arawal, jamie.bainbridge, Abhishek Rawal, linux-usb, netdev,
	linux-kernel

From: Abhishek Rawal <rawal.abhishek92@gmail.com>

Driver calls skb_tx_timestamp(skb) in rtl8152_start_xmit(), but does not advertise the capability in ethtool.
Advertise software timestamp capabilities on struct ethtool_ops.

Signed-off-by: Abhishek Rawal <rawal.abhishek92@gmail.com>
Reviewed-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
---
 drivers/net/usb/r8152.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
index 44cba7acfe7d9bfbcc96a1e974762657bd1c3c33..f896e9f28c3b0ce2282912c9ea37820160df3a45 100644
--- a/drivers/net/usb/r8152.c
+++ b/drivers/net/usb/r8152.c
@@ -9311,6 +9311,7 @@ static const struct ethtool_ops ops = {
 	.set_ringparam = rtl8152_set_ringparam,
 	.get_pauseparam = rtl8152_get_pauseparam,
 	.set_pauseparam = rtl8152_set_pauseparam,
+	.get_ts_info = ethtool_op_get_ts_info,
 };
 
 static int rtl8152_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)
-- 
2.51.0


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] r8152: Advertise software timestamp information.
  2025-10-14  5:52 [PATCH net-next] r8152: Advertise software timestamp information rawal.abhishek92
@ 2025-10-14 11:05 ` Vadim Fedorenko
  2025-10-15 20:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: Vadim Fedorenko @ 2025-10-14 11:05 UTC (permalink / raw)
  To: rawal.abhishek92, Andrew Lunn, David S. Miller, Eric Dumazet,
	Jakub Kicinski, Paolo Abeni
  Cc: arawal, jamie.bainbridge, linux-usb, netdev, linux-kernel

On 14/10/2025 06:52, rawal.abhishek92@gmail.com wrote:
> From: Abhishek Rawal <rawal.abhishek92@gmail.com>
> 
> Driver calls skb_tx_timestamp(skb) in rtl8152_start_xmit(), but does not advertise the capability in ethtool.
> Advertise software timestamp capabilities on struct ethtool_ops.
> 
> Signed-off-by: Abhishek Rawal <rawal.abhishek92@gmail.com>
> Reviewed-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
> ---
>   drivers/net/usb/r8152.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/net/usb/r8152.c b/drivers/net/usb/r8152.c
> index 44cba7acfe7d9bfbcc96a1e974762657bd1c3c33..f896e9f28c3b0ce2282912c9ea37820160df3a45 100644
> --- a/drivers/net/usb/r8152.c
> +++ b/drivers/net/usb/r8152.c
> @@ -9311,6 +9311,7 @@ static const struct ethtool_ops ops = {
>   	.set_ringparam = rtl8152_set_ringparam,
>   	.get_pauseparam = rtl8152_get_pauseparam,
>   	.set_pauseparam = rtl8152_set_pauseparam,
> +	.get_ts_info = ethtool_op_get_ts_info,
>   };
>   
>   static int rtl8152_ioctl(struct net_device *netdev, struct ifreq *rq, int cmd)

Reviewed-by: Vadim Fedorenko <vadim.fedorenko@linux.dev>

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH net-next] r8152: Advertise software timestamp information.
  2025-10-14  5:52 [PATCH net-next] r8152: Advertise software timestamp information rawal.abhishek92
  2025-10-14 11:05 ` Vadim Fedorenko
@ 2025-10-15 20:40 ` patchwork-bot+netdevbpf
  1 sibling, 0 replies; 3+ messages in thread
From: patchwork-bot+netdevbpf @ 2025-10-15 20:40 UTC (permalink / raw)
  To: Abhishek Rawal
  Cc: andrew+netdev, davem, edumazet, kuba, pabeni, arawal,
	jamie.bainbridge, linux-usb, netdev, linux-kernel

Hello:

This patch was applied to netdev/net-next.git (main)
by Jakub Kicinski <kuba@kernel.org>:

On Tue, 14 Oct 2025 11:22:33 +0530 you wrote:
> From: Abhishek Rawal <rawal.abhishek92@gmail.com>
> 
> Driver calls skb_tx_timestamp(skb) in rtl8152_start_xmit(), but does not advertise the capability in ethtool.
> Advertise software timestamp capabilities on struct ethtool_ops.
> 
> Signed-off-by: Abhishek Rawal <rawal.abhishek92@gmail.com>
> Reviewed-by: Jamie Bainbridge <jamie.bainbridge@gmail.com>
> 
> [...]

Here is the summary with links:
  - [net-next] r8152: Advertise software timestamp information.
    https://git.kernel.org/netdev/net-next/c/a8e846b8d93d

You are awesome, thank you!
-- 
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html



^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2025-10-15 20:40 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2025-10-14  5:52 [PATCH net-next] r8152: Advertise software timestamp information rawal.abhishek92
2025-10-14 11:05 ` Vadim Fedorenko
2025-10-15 20:40 ` patchwork-bot+netdevbpf

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).