From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kleber Sacilotto de Souza Subject: Re: [PATCH] mlx4: Add support for EEH error recovery Date: Tue, 24 Jul 2012 14:35:51 -0300 Message-ID: <500EDCF7.3010500@linux.vnet.ibm.com> References: <1342814143-5744-1-git-send-email-klebers@linux.vnet.ibm.com> <500BD558.2060803@mellanox.com> <20120722.171553.2139258607165498367.davem@davemloft.net> <500D4F31.9020408@linux.vnet.ibm.com> <500D556F.4000409@mellanox.com> <500D93F5.4090305@linux.vnet.ibm.com> <500DB9CE.5080100@linux.vnet.ibm.com> <500E9F2E.4010209@linux.vnet.ibm.com> <500ED6E4.60909@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Cc: Or Gerlitz , Or Gerlitz , David Miller , netdev@vger.kernel.org, jackm@dev.mellanox.co.il, yevgenyp@mellanox.co.il, cascardo@linux.vnet.ibm.com, brking@linux.vnet.ibm.com To: Shlomo Pongartz Return-path: Received: from e24smtp04.br.ibm.com ([32.104.18.25]:35917 "EHLO e24smtp04.br.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755139Ab2GXRf6 (ORCPT ); Tue, 24 Jul 2012 13:35:58 -0400 Received: from /spool/local by e24smtp04.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Tue, 24 Jul 2012 14:35:55 -0300 Received: from d24relay03.br.ibm.com (d24relay03.br.ibm.com [9.13.184.25]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 9D0881DC004F for ; Tue, 24 Jul 2012 13:35:53 -0400 (EDT) Received: from d24av01.br.ibm.com (d24av01.br.ibm.com [9.8.31.91]) by d24relay03.br.ibm.com (8.13.8/8.13.8/NCO v10.0) with ESMTP id q6OHZ6QB24903704 for ; Tue, 24 Jul 2012 14:35:06 -0300 Received: from d24av01.br.ibm.com (loopback [127.0.0.1]) by d24av01.br.ibm.com (8.14.4/8.13.1/NCO v10.0 AVout) with ESMTP id q6OFZlZH010778 for ; Tue, 24 Jul 2012 12:35:48 -0300 In-Reply-To: <500ED6E4.60909@mellanox.com> Sender: netdev-owner@vger.kernel.org List-ID: On 07/24/2012 02:09 PM, Shlomo Pongartz wrote: > On 7/24/2012 4:12 PM, Kleber Sacilotto de Souza wrote: >> On 07/23/2012 06:26 PM, Or Gerlitz wrote: >> >>> Kleber Sacilotto de Souza wrote: >>>>> For powerpc we have an IBM internal user space tool that injects the >>>>> error on the bus with the aid of the system firmware. The kernel used >>>>> was built with the option: >>>>> CONFIG_EEH=y >>>>> and without the AER options. I will run some more tests with the AER >>>>> options activated. >>>> I tested the powerpc error injection with >>>> >>>> CONFIG_EEH=y >>>> CONFIG_PCIEAER=y >>>> CONFIG_PCIEAER_INJECT=m >>>> >>>> and with the aer_inject module loaded and it didn't affect the EEH >>>> recovery, the adapter recovered as expected. >>> I wasn't sure to follow what did you mean by "it didn't affect the EEH >>> recovery", how did you use the aer_inject module, is that through >>> user-space tool which is available for us? >> >> I wanted to say that I was testing before only with the EEH option >> activated, then I activated the AER options on my powerpc system just to >> make sure these options when activate wouldn't affect the EEH recovery. >> I haven't injected and AER error since I don't have a system with >> hardware support for it. >> >> >> Thanks, > > Hi > > Using a special extender card I've powered down the card. > None of the callbacks were called (I added printks to be sure). > Shouldn't one on the callbacks be called? > > Shlomo Pongratz. > What does this extender card do exactly? If it does hot plugging, it will call the remove and probe callbacks. -- Kleber Sacilotto de Souza IBM Linux Technology Center