From: "Nicolas de Pesloüan" <nicolas.2p.debian@gmail.com>
To: David Miller <davem@davemloft.net>
Cc: netdev@vger.kernel.org, ja@ssi.bg, Jiri Pirko <jiri@resnulli.us>
Subject: Re: [PATCH 2/3] net: Make skb->skb_iif always track skb->dev
Date: Tue, 24 Jul 2012 23:43:25 +0200 [thread overview]
Message-ID: <500F16FD.9070506@gmail.com> (raw)
In-Reply-To: <20120723.164542.1890653324956444632.davem@davemloft.net>
Le 24/07/2012 01:45, David Miller a écrit :
>
> Make it follow device decapsulation, from things such as VLAN and
> bonding.
>
> The stuff that actually cares about pre-demuxed device pointers, is
> handled by the "orig_dev" variable in __netif_receive_skb(). And
> the only consumer of that is the po->origdev feature of AF_PACKET
> sockets.
>
> Signed-off-by: David S. Miller<davem@davemloft.net>
Jiri tried to remove this orig_dev usage in af_packet in march 2011, without success, by using the
value of skb_iif instead :-)
In case my opinion might be relevant:
Reviewed-by: Nicolas de Pesloüan <nicolas.2p.debian@free.fr>
Nicolas.
prev parent reply other threads:[~2012-07-24 21:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-23 23:45 [PATCH 2/3] net: Make skb->skb_iif always track skb->dev David Miller
2012-07-24 21:43 ` Nicolas de Pesloüan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500F16FD.9070506@gmail.com \
--to=nicolas.2p.debian@gmail.com \
--cc=davem@davemloft.net \
--cc=ja@ssi.bg \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).