From: Hau <hau@realtek.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: "hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
nic_swsd <nic_swsd@realtek.com>
Subject: RE: [PATCH net-next] r8169: add rtl_disable_rxdvgate()
Date: Wed, 28 Sep 2022 12:23:16 +0000 [thread overview]
Message-ID: <500db480aa314e4d96c0a7f6a9da1260@realtek.com> (raw)
In-Reply-To: <20220927173810.6caad4f3@kernel.org>
>
> On Mon, 26 Sep 2022 15:48:13 +0800 Chunhao Lin wrote:
> > rtl_disable_rxdvgate() is used for disable RXDV_GATE.
> > It is opposite function of rtl_enable_rxdvgate().
>
> You should mention that you're dropping the udelay() and if you know why it
> was there in the first place - why it's no longer needed.
>
I will update the commit message and resubmit the patch.
Thanks.
------Please consider the environment before printing this e-mail.
prev parent reply other threads:[~2022-09-28 12:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-26 7:48 [PATCH net-next] r8169: add rtl_disable_rxdvgate() Chunhao Lin
2022-09-28 0:38 ` Jakub Kicinski
2022-09-28 12:23 ` Hau [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=500db480aa314e4d96c0a7f6a9da1260@realtek.com \
--to=hau@realtek.com \
--cc=hkallweit1@gmail.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
--cc=nic_swsd@realtek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).