Re: [PATCH] igb: reduce Rx header size

[Alexander Duyck <alexander.h.duyck@intel.com>]

On 08/02/2012 08:15 AM, Eric Dumazet wrote:
> From: Eric Dumazet <edumazet@google.com>
>
> Reduce skb truesize by 256 bytes.
>
> Signed-off-by: Eric Dumazet <edumazet@google.com>
> Cc: Alexander Duyck <alexander.h.duyck@intel.com>
> ---
> Tested on my machine without any problem
>
>  drivers/net/ethernet/intel/igb/igb.h |    4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/ethernet/intel/igb/igb.h b/drivers/net/ethernet/intel/igb/igb.h
> index 9e572dd..0c9f62c 100644
> --- a/drivers/net/ethernet/intel/igb/igb.h
> +++ b/drivers/net/ethernet/intel/igb/igb.h
> @@ -131,9 +131,9 @@ struct vf_data_storage {
>  #define MAXIMUM_ETHERNET_VLAN_SIZE 1522
>  
>  /* Supported Rx Buffer Sizes */
> -#define IGB_RXBUFFER_512   512
> +#define IGB_RXBUFFER_256   256
>  #define IGB_RXBUFFER_16384 16384
> -#define IGB_RX_HDR_LEN     IGB_RXBUFFER_512
> +#define IGB_RX_HDR_LEN     IGB_RXBUFFER_256
>  
>  /* How many Tx Descriptors do we need to call netif_wake_queue ? */
>  #define IGB_TX_QUEUE_WAKE	16
>
>
Would there be any problems with us running this through Jeff's tree for
testing prior to applying this?  I'm just wanting to do some testing
internally for any performance regressions due to this change.

Thanks,

Alex