From: Paolo Abeni <pabeni@redhat.com>
To: Jakub Kicinski <kuba@kernel.org>, davem@davemloft.net
Cc: netdev@vger.kernel.org, edumazet@google.com,
alexanderduyck@fb.com, kernel-team@meta.com
Subject: Re: [PATCH net v2] eth: fbnic: don't build the driver when skb has more than 21 frags
Date: Thu, 18 Jul 2024 15:25:18 +0200 [thread overview]
Message-ID: <5021a2aa-1398-4b3d-b1fc-6bbb2d85dfbb@redhat.com> (raw)
In-Reply-To: <20240717161600.1291544-1-kuba@kernel.org>
On 7/17/24 18:15, Jakub Kicinski wrote:
> Similarly to commit 0e03c643dc93 ("eth: fbnic: fix s390 build."),
> the driver won't build if skb_shared_info has more than 25 frags
> assuming a 64B cache line and 21 frags assuming a 128B cache line.
>
> (512 - 48 - 64) / 16 = 25
> (512 - 48 - 128) / 16 = 21
>
> Fixes: 0cb4c0a13723 ("eth: fbnic: Implement Rx queue alloc/start/stop/free")
> Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Acked-by: Paolo Abeni <pabeni@redhat.com>
next prev parent reply other threads:[~2024-07-18 13:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-17 16:15 [PATCH net v2] eth: fbnic: don't build the driver when skb has more than 21 frags Jakub Kicinski
2024-07-18 13:25 ` Paolo Abeni [this message]
2024-07-19 14:40 ` patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5021a2aa-1398-4b3d-b1fc-6bbb2d85dfbb@redhat.com \
--to=pabeni@redhat.com \
--cc=alexanderduyck@fb.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kernel-team@meta.com \
--cc=kuba@kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).