From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Wagner Subject: Re: [PATCH v3 6/6] cgroup: Assign subsystem IDs during compile time Date: Tue, 14 Aug 2012 23:01:28 +0200 Message-ID: <502ABCA8.1000008@monom.org> References: <1344949343-26090-1-git-send-email-wagi@monom.org> <1344949343-26090-8-git-send-email-wagi@monom.org> <20120814172749.GL25632@google.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, cgroups-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Daniel Wagner , "David S. Miller" , Andrew Morton , Eric Dumazet , Gao feng , Glauber Costa , Jamal Hadi Salim , John Fastabend , Kamezawa Hiroyuki , Li Zefan , Neil Horman To: Tejun Heo Return-path: In-Reply-To: <20120814172749.GL25632-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org> Sender: cgroups-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org List-Id: netdev.vger.kernel.org Hi Tejun, On 08/14/2012 07:27 PM, Tejun Heo wrote: > On Tue, Aug 14, 2012 at 03:02:23PM +0200, Daniel Wagner wrote: >> From: Daniel Wagner >> >> We are able to safe some space when we assign the subsystem >> IDs at compile time. Instead of allocating per cgroup >> cgroup->subsys[CGROUP_SUBSYS_COUNT] where CGROUP_SUBSYS_COUNT is >> always 64, we allocate 12 + 1 at max (at this point there are 12 >> subsystem). The additinal one is the price we have to pay to >> distinguish between builtin and module subsystems. >> >> We should only access task_cls_classid() and task_netprioidx() >> if the subsystem is ready to be used using jump labels for this. > > I think I want to like this patch but it's kinda confusing to review. > Is there any reasonable way that you can split the core changes from > net_cls ones? My bad, sorry about that. Sure, I'll split the patches into smaller pieces and remove net_cls updating part as Neil has requested. You will get someting to review on Thursday, since tomorrow I am out of office. thanks, daniel