From: David Ahern <dsahern@gmail.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, Hangbin Liu <liuhangbin@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>
Subject: Re: [Patch net v3 2/2] selftests: add a test case for rp_filter
Date: Mon, 15 Nov 2021 09:06:50 -0700 [thread overview]
Message-ID: <50364490-9e86-a26e-3a56-78459b3b5151@gmail.com> (raw)
In-Reply-To: <CAM_iQpV99vbCOZUj_9chHt8TXeiXqbvwKW7r8T9t1hpTa79qdQ@mail.gmail.com>
On 11/14/21 10:08 PM, Cong Wang wrote:
> On Wed, Nov 10, 2021 at 1:18 AM Hangbin Liu <liuhangbin@gmail.com> wrote:
>>
>> On Wed, Jul 17, 2019 at 02:41:59PM -0700, Cong Wang wrote:
>>> Add a test case to simulate the loopback packet case fixed
>>> in the previous patch.
>>>
>>> This test gets passed after the fix:
>>>
>>> IPv4 rp_filter tests
>>> TEST: rp_filter passes local packets [ OK ]
>>> TEST: rp_filter passes loopback packets [ OK ]
>>
>> Hi Wang Cong,
>>
>> Have you tried this test recently? I got this test failed for a long time.
>> Do you have any idea?
>>
>> IPv4 rp_filter tests
>> TEST: rp_filter passes local packets [FAIL]
>> TEST: rp_filter passes loopback packets [FAIL]
>
> Hm, I think another one also reported this before, IIRC, it is
> related to ping version or cmd option. Please look into this if
> you can, otherwise I will see if I can reproduce this on my side.
>
The test does 'ping -I dummy1'. As I recall newer version of ping uses
SO_BINDTODEVICE vs cmsg to specify the device binding. The setsockopt is
stronger and I bet the socket lookup is failing. If that is the case,
the test needs to be fixed because it will never pass again.
next prev parent reply other threads:[~2021-11-15 16:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-17 21:41 [Patch net v3 0/2] ipv4: relax source validation check for loopback packets Cong Wang
2019-07-17 21:41 ` [Patch net v3 1/2] fib: " Cong Wang
2019-07-17 21:59 ` David Ahern
2019-07-17 21:41 ` [Patch net v3 2/2] selftests: add a test case for rp_filter Cong Wang
2019-07-17 21:54 ` David Ahern
2021-11-10 9:18 ` Hangbin Liu
2021-11-15 5:08 ` Cong Wang
2021-11-15 16:06 ` David Ahern [this message]
2021-11-17 3:19 ` Hangbin Liu
2021-11-17 4:15 ` David Ahern
2021-11-24 1:05 ` Cong Wang
2021-11-24 1:43 ` Hangbin Liu
2021-11-29 6:40 ` Peilin Ye
2019-07-17 22:23 ` [Patch net v3 0/2] ipv4: relax source validation check for loopback packets David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=50364490-9e86-a26e-3a56-78459b3b5151@gmail.com \
--to=dsahern@gmail.com \
--cc=liuhangbin@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).