From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Fastabend Subject: Re: [RFC PATCH] net: Add support for virtual machine device queues (VMDQ) Date: Mon, 27 Aug 2012 10:21:28 -0700 Message-ID: <503BAC98.2070508@intel.com> References: <20120718220544.22619.97136.stgit@i40e.jf1> <503A7462.1030803@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: davem@davemloft.net, roland@kernel.org, netdev@vger.kernel.org, ali@mellanox.com, sean.hefty@intel.com, shlomop@mellanox.com To: Or Gerlitz Return-path: Received: from mga09.intel.com ([134.134.136.24]:55613 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753179Ab2H0RVe (ORCPT ); Mon, 27 Aug 2012 13:21:34 -0400 In-Reply-To: Sender: netdev-owner@vger.kernel.org List-ID: On 8/27/2012 2:47 AM, Or Gerlitz wrote: > On Sun, Aug 26, 2012 at 10:09 PM, John Fastabend > wrote: >> That seems reasonable to me. Adding a 'sub' argument to the set >> routines should do it. Also the 'get' routines would need to be >> extended to report back these virtual net devices. >> >> int (*ndo_set_vf_mac)(struct net_device *dev, int vf, int sub, u8* mac); >> int (*ndo_set_vf_vlan)(struct net_device *dev, >> int vf, int sub, u16 vlan, u8 qos); >> int (*ndo_set_vf_tx_rate)(struct net_device *dev, >> int vf, int sub, int rate); >> int (*ndo_set_vf_spoofchk)(struct net_device *dev, >> int vf, int sub, bool setting); >> int (*ndo_get_vf_config)(struct net_device *dev, >> int vf, int sub, >> struct fila_vf_info *ivf) > >> I would need to check if any of the ixgbe/igb supported hardware can >> support virtual device queues on virtual functions like this but I >> presume if your looking at this you have some hardware that can. > > Yes, we look on HW that can. > > Your suggestion makes sense, I will check here if this well addresses > the eswitch > use case we envision or/what is missing. > > Or. > Sounds good let us know. Ben had some comments I need to address as well. .John