From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from server.wki.vra.mybluehostin.me (server.wki.vra.mybluehostin.me [162.240.238.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C29037FD; Wed, 29 Jan 2025 05:17:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=162.240.238.73 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738127839; cv=none; b=IH4LltgcM/w2t03nnYexLgJgkCzL4dGIHfZTXx07YZeabE/dEO6/IZZZdG0DhJtZRBYjYFxiYCoBeAVbJ3HP+p4jQiY42H0rM22UWkabuRctqvBSVgpRUCbmsd5S4kX07wrxO8Y3vJEDSuR5CJNlkRndy6h/y43Wt4NnT2BT2+E= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1738127839; c=relaxed/simple; bh=2nfnAyTgWaLM6lm9ZlOh3dAoXGYTuHdqbCHqHLXCdeE=; h=Date:From:To:Cc:Message-ID:In-Reply-To:References:Subject: MIME-Version:Content-Type; b=eGp9hPQetibh9OPYneBLd9yaWdcxfQOzcRzbOI1aDZFSlldUps0j/TjPZSNbhZG8/0O4hDRQj/oPSJF45gpAoLlueGylJLj+xYGWn2Wzn9hbg+SmjhhsDisNrj+rUdSNx/rD8pgHi+7m2xPjGGyamdp8xIedYJJCin5hWDGi3d0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=couthit.com; spf=pass smtp.mailfrom=couthit.com; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b=JBMSSnx0; arc=none smtp.client-ip=162.240.238.73 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=couthit.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=couthit.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=couthit.com header.i=@couthit.com header.b="JBMSSnx0" DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=couthit.com ; s=default; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Subject: References:In-Reply-To:Message-ID:Cc:To:From:Date:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=X6Ju9BCFYDjOd/uHCN0vNapSKcR/GM45kfkgX04XSwI=; b=JBMSSnx0ctcUYymHts7Gah/74C uFJs40C9SuKFUCAGes1zpMOzwn/FLcNG+oGV9cCjgoj0ZFeByzHZBBWhFsDmUBYzf/N3NL5g8twZW ZlNkke/Rw9YjVqrLCxixzAUC+0xUuZ1gQ5Nc1SAb4VLP+TcqZ3odfli7pwvNW///1Q47VTcicH/ER nhBXYjJ6vnXO8l0RK1gEmJZFhiopx8TPLjzgY9NKZksO42RtUjp6m3DZBfY4h6z8wd2YYB/ivF6lU Dc+qFBVJl3vvYECMAxaJgpenkTYJ211Xbo1ui6u6gyh7YFMa0Zmdla+Ohnt0xWBX2xfSzju0pT0h9 Sng5bwnQ==; Received: from [122.175.9.182] (port=54277 helo=zimbra.couthit.local) by server.wki.vra.mybluehostin.me with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.96.2) (envelope-from ) id 1td0Ri-0007Uj-1t; Wed, 29 Jan 2025 10:47:02 +0530 Received: from zimbra.couthit.local (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTPS id 1159A17823F4; Wed, 29 Jan 2025 10:46:53 +0530 (IST) Received: from localhost (localhost [127.0.0.1]) by zimbra.couthit.local (Postfix) with ESMTP id E0F021782431; Wed, 29 Jan 2025 10:46:52 +0530 (IST) Received: from zimbra.couthit.local ([127.0.0.1]) by localhost (zimbra.couthit.local [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id KyvCiIamOabA; Wed, 29 Jan 2025 10:46:52 +0530 (IST) Received: from zimbra.couthit.local (zimbra.couthit.local [10.10.10.103]) by zimbra.couthit.local (Postfix) with ESMTP id 9399417823F4; Wed, 29 Jan 2025 10:46:52 +0530 (IST) Date: Wed, 29 Jan 2025 10:46:52 +0530 (IST) From: Basharath Hussain Khaja To: Conor Dooley Cc: basharath , danishanwar , rogerq , andrew+netdev , davem , edumazet , kuba , pabeni , Rob Herring , krzk+dt , conor+dt , nm , ssantosh , tony , richardcochran , parvathi , schnelle , rdunlap , diogo ivo , m-karicheri2 , horms , jacob e keller , m-malladi , javier carrasco cruz , afd , s-anna , linux-arm-kernel , netdev , devicetree , linux-kernel , linux-omap , pratheesh , prajith , vigneshr , praneeth , srk , rogerq , krishna , pmohan , mohan Message-ID: <504387436.449923.1738127812232.JavaMail.zimbra@couthit.local> In-Reply-To: <20250124-reoccupy-music-3803c753f8af@spud> References: <20250124122353.1457174-1-basharath@couthit.com> <20250124122353.1457174-2-basharath@couthit.com> <20250124-reoccupy-music-3803c753f8af@spud> Subject: Re: [RFC v2 PATCH 01/10] dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs Precedence: bulk X-Mailing-List: netdev@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Mailer: Zimbra 8.8.15_GA_3968 (ZimbraWebClient - FF113 (Linux)/8.8.15_GA_3968) Thread-Topic: dt-bindings: net: ti: Adds DUAL-EMAC mode support on PRU-ICSS2 for AM57xx SOCs Thread-Index: 6LML00aApm6KpgWq7NZwIddzwdB6BQ== X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - server.wki.vra.mybluehostin.me X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - couthit.com X-Get-Message-Sender-Via: server.wki.vra.mybluehostin.me: authenticated_id: smtp@couthit.com X-Authenticated-Sender: server.wki.vra.mybluehostin.me: smtp@couthit.com X-Source: X-Source-Args: X-Source-Dir: > On Fri, Jan 24, 2025 at 05:53:44PM +0530, Basharath Hussain Khaja wrote: >> From: Parvathi Pudi >> >> Documentation update for the newly added "pruss2_eth" device tree >> node and its dependencies along with compatibility for PRU-ICSS >> Industrial Ethernet Peripheral (IEP), PRU-ICSS Enhanced Capture >> (eCAP) peripheral and using YAML binding document for AM57xx SoCs. >> >> Signed-off-by: Roger Quadros >> Signed-off-by: Andrew F. Davis >> Signed-off-by: Murali Karicheri >> Signed-off-by: Parvathi Pudi >> Signed-off-by: Basharath Hussain Khaja > > I find this hard to believe. If all these people handled the patch, the > signoff from Parvathi would be first, no? Should some of these people be > co-developers? > Changes are about multiple modules. We have added our sign-off followed by original module authors. >> --- >> .../devicetree/bindings/net/ti,icss-iep.yaml | 5 + >> .../bindings/net/ti,icssm-prueth.yaml | 147 ++++++++++++++++++ >> .../bindings/net/ti,pruss-ecap.yaml | 32 ++++ >> .../devicetree/bindings/soc/ti/ti,pruss.yaml | 9 ++ >> 4 files changed, 193 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml >> create mode 100644 Documentation/devicetree/bindings/net/ti,pruss-ecap.yaml >> >> diff --git a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> index e36e3a622904..aad7d37fb47e 100644 >> --- a/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> +++ b/Documentation/devicetree/bindings/net/ti,icss-iep.yaml >> @@ -8,6 +8,8 @@ title: Texas Instruments ICSS Industrial Ethernet Peripheral >> (IEP) module >> >> maintainers: >> - Md Danish Anwar >> + - Parvathi Pudi >> + - Basharath Hussain Khaja >> >> properties: >> compatible: >> @@ -20,6 +22,9 @@ properties: >> >> - const: ti,am654-icss-iep >> >> + - items: >> + - enum: >> + - ti,am5728-icss-iep > > "items: - enum: " is the same as const. > Sure, we will modify as below. - const: ti,am5728-icss-iep >> >> reg: >> maxItems: 1 >> diff --git a/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml >> b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml >> new file mode 100644 >> index 000000000000..51e99beb5f5f >> --- /dev/null >> +++ b/Documentation/devicetree/bindings/net/ti,icssm-prueth.yaml >> @@ -0,0 +1,147 @@ >> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) >> +%YAML 1.2 >> +--- >> +$id: http://devicetree.org/schemas/net/ti,icssm-prueth.yaml# >> +$schema: http://devicetree.org/meta-schemas/core.yaml# >> + >> +title: Texas Instruments ICSSM PRUSS Ethernet >> + >> +maintainers: >> + - Roger Quadros >> + - Andrew F. Davis >> + - Parvathi Pudi >> + - Basharath Hussain Khaja >> + >> +description: >> + Ethernet based on the Programmable Real-Time Unit and Industrial >> + Communication Subsystem. >> + >> +properties: >> + compatible: >> + enum: >> + - ti,am57-prueth # for AM57x SoC family >> + >> + sram: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to OCMC SRAM node >> + >> + ti,mii-rt: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to MII_RT module's syscon regmap >> + >> + ti,iep: >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to IEP (Industrial Ethernet Peripheral) for ICSS >> + >> + ecap: > > Why's this one not got a ti prefix? > We will add "ti" prefix to ecap as "ti,ecap" in the next version. >> + $ref: /schemas/types.yaml#/definitions/phandle >> + description: >> + phandle to Enhanced Capture (eCAP) event for ICSS > > Why do you need phandles for these things, can they not be looked up by > compatible? (e.g. multiple devices on one SoC). > ecap is another peripheral similar to IEP in ICSSM/ICSSG. We have created a separate driver for possible reuse with ICSSG in future. >> + >> + interrupts: >> + items: >> + - description: High priority Rx Interrupt specifier. > > + - description: Low priority Rx Interrupt specifier. Thanks & Best Regards, Basharath