From: Randy Dunlap <rdunlap@xenotime.net>
To: Timur Tabi <timur@freescale.com>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
linux-next@vger.kernel.org, sfr@canb.auug.org.au
Subject: Re: [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h
Date: Fri, 07 Sep 2012 16:42:26 -0700 [thread overview]
Message-ID: <504A8662.9050907@xenotime.net> (raw)
In-Reply-To: <1347053457-24935-1-git-send-email-timur@freescale.com>
On 09/07/2012 02:30 PM, Timur Tabi wrote:
> mdio-mux-mmioreg.c uses function of_address_to_resource(), which is defined
> in linux/of_address.h. This fixes a compilation error:
>
> drivers/net/phy/mdio-mux-mmioreg.c: In function 'mdio_mux_mmioreg_probe':
> drivers/net/phy/mdio-mux-mmioreg.c:83:2: error: implicit declaration of
> function 'of_address_to_resource'
>
> Reported-by: Randy Dunlap <rdunlap@xenotime.net>
> Signed-off-by: Timur Tabi <timur@freescale.com>
>
Acked-by: Randy Dunlap <rdunlap@xenotime.net>
Thanks.
> ---
> drivers/net/phy/mdio-mux-mmioreg.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/drivers/net/phy/mdio-mux-mmioreg.c b/drivers/net/phy/mdio-mux-mmioreg.c
> index 098239a..9061ba6 100644
> --- a/drivers/net/phy/mdio-mux-mmioreg.c
> +++ b/drivers/net/phy/mdio-mux-mmioreg.c
> @@ -12,6 +12,7 @@
>
> #include <linux/platform_device.h>
> #include <linux/device.h>
> +#include <linux/of_address.h>
> #include <linux/of_mdio.h>
> #include <linux/module.h>
> #include <linux/init.h>
--
~Randy
prev parent reply other threads:[~2012-09-07 23:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-07 21:30 [PATCH][v2] netdev/phy: mdio-mux-mmioreg.c should include of_address.h Timur Tabi
2012-09-07 21:32 ` David Miller
2012-09-07 23:42 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=504A8662.9050907@xenotime.net \
--to=rdunlap@xenotime.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=sfr@canb.auug.org.au \
--cc=timur@freescale.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).